github/verilator
1
0
Fork 1
mirror of https://github.com/verilator/verilator.git synced 2025-05-01 21:16:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix pattern replication without key.

Browse Source
This commit is contained in:
Wilson Snyder 2020-01-26 11:38:34 -05:00
parent b50ef9ff39
commit cac50282eb
2 changed files with 22 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/V3Width.cpp
View File

@ -2300,9 +2300,10 @@ private:
patp->unlinkFrBack(&relinkHandle); patp->unlinkFrBack(&relinkHandle);
while (AstNode* movep = patp->lhssp()->nextp()) { while (AstNode* movep = patp->lhssp()->nextp()) {
movep->unlinkFrBack(); // Not unlinkFrBackWithNext, just one movep->unlinkFrBack(); // Not unlinkFrBackWithNext, just one
AstNode* newkeyp = NULL;
if (patp->keyp()) newkeyp = patp->keyp()->cloneTree(true);
AstPatMember* newp AstPatMember* newp
= new AstPatMember(patp->fileline(), movep, = new AstPatMember(patp->fileline(), movep, newkeyp, NULL);
patp->keyp()->cloneTree(true), NULL);
patp->addNext(newp); patp->addNext(newp);
} }
relinkHandle.relink(patp); relinkHandle.relink(patp);

24
test_regress/t/t_array_pattern_unpacked.v
View File

@ -7,14 +7,18 @@ module t (/*AUTOARG*/);
logic [3:0] array_simp [1:0] [3:0]; // big endian array logic [3:0] array_simp [1:0] [3:0]; // big endian array
int irep[1:2][1:6];
initial begin initial begin
array_simp[0] = '{ 4'd3, 4'd2, 4'd1, 4'd0}; array_simp[0] = '{ 4'd3, 4'd2, 4'd1, 4'd0};
if ({array_simp[0][3],array_simp[0][2],array_simp[0][1],array_simp[0][0]} !== 16'h3210) $stop; if ({array_simp[0][3],array_simp[0][2],array_simp[0][1],array_simp[0][0]}
!== 16'h3210) $stop;
// verilator lint_off WIDTH // verilator lint_off WIDTH
array_simp[0] = '{ 3 ,2 ,1, 0 }; array_simp[0] = '{ 3 ,2 ,1, 0 };
// verilator lint_on WIDTH // verilator lint_on WIDTH
if ({array_simp[0][3],array_simp[0][2],array_simp[0][1],array_simp[0][0]} !== 16'h3210) $stop; if ({array_simp[0][3],array_simp[0][2],array_simp[0][1],array_simp[0][0]}
!== 16'h3210) $stop;
// Doesn't seem to work for unpacked arrays in other simulators // Doesn't seem to work for unpacked arrays in other simulators
//array_simp[0] = '{ 1:4'd3, default:13 }; //array_simp[0] = '{ 1:4'd3, default:13 };
@ -22,21 +26,31 @@ module t (/*AUTOARG*/);
array_simp = '{ '{ 4'd3, 4'd2, 4'd1, 4'd0 }, '{ 4'd1, 4'd2, 4'd3, 4'd4 }}; array_simp = '{ '{ 4'd3, 4'd2, 4'd1, 4'd0 }, '{ 4'd1, 4'd2, 4'd3, 4'd4 }};
if ({array_simp[1][3],array_simp[1][2],array_simp[1][1],array_simp[1][0], if ({array_simp[1][3],array_simp[1][2],array_simp[1][1],array_simp[1][0],
array_simp[0][3],array_simp[0][2],array_simp[0][1],array_simp[0][0]} !== 32'h3210_1234) $stop; array_simp[0][3],array_simp[0][2],array_simp[0][1],array_simp[0][0]}
!== 32'h3210_1234) $stop;
// Doesn't seem to work for unpacked arrays in other simulators // Doesn't seem to work for unpacked arrays in other simulators
array_simp = '{2{ '{4'd3, 4'd2, 4'd1, 4'd0 } }}; array_simp = '{2{ '{4'd3, 4'd2, 4'd1, 4'd0 } }};
if ({array_simp[1][3],array_simp[1][2],array_simp[1][1],array_simp[1][0], if ({array_simp[1][3],array_simp[1][2],array_simp[1][1],array_simp[1][0],
array_simp[0][3],array_simp[0][2],array_simp[0][1],array_simp[0][0]} !== 32'h3210_3210) $stop; array_simp[0][3],array_simp[0][2],array_simp[0][1],array_simp[0][0]}
!== 32'h3210_3210) $stop;
array_simp = '{2{ '{4{ 4'd3 }} }}; array_simp = '{2{ '{4{ 4'd3 }} }};
if ({array_simp[1][3],array_simp[1][2],array_simp[1][1],array_simp[1][0], if ({array_simp[1][3],array_simp[1][2],array_simp[1][1],array_simp[1][0],
array_simp[0][3],array_simp[0][2],array_simp[0][1],array_simp[0][0]} !== 32'h3333_3333) $stop; array_simp[0][3],array_simp[0][2],array_simp[0][1],array_simp[0][0]}
!== 32'h3333_3333) $stop;
// Not legal in other simulators - replication doesn't match // Not legal in other simulators - replication doesn't match
// However IEEE suggests this is legal. // However IEEE suggests this is legal.
//array_simp = '{2{ '{2{ 4'd3, 4'd2 }} }}; // Note it's not '{3,2} //array_simp = '{2{ '{2{ 4'd3, 4'd2 }} }}; // Note it's not '{3,2}
// Replication
irep = '{2{ '{3 {4, 5}}}};
if ({irep[1][1], irep[1][2], irep[1][3], irep[1][4], irep[1][5], irep[1][6]}
!= {32'h4, 32'h5, 32'h4, 32'h5, 32'h4, 32'h5}) $stop;
if ({irep[2][1], irep[2][2], irep[2][3], irep[2][4], irep[2][5], irep[2][6]}
!= {32'h4, 32'h5, 32'h4, 32'h5, 32'h4, 32'h5}) $stop;
$write("*-* All Finished *-*\n"); $write("*-* All Finished *-*\n");
$finish; $finish;
end end