github/verilator
1
0
Fork 1
mirror of https://github.com/verilator/verilator.git synced 2025-04-05 20:22:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

Improve DEFPARAM warning text.

Browse Source
This commit is contained in:
Wilson Snyder 2021-03-14 20:36:43 -04:00
parent 50866e470a
commit ba1f53a070
3 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
docs/xml.rst
View File

@ -69,7 +69,6 @@ The XML document consists of 4 sections within the top level
by elements in the ``<module>`` elements using the ``dtype_id`` by elements in the ``<module>`` elements using the ``dtype_id``
attribute. attribute.
.. __distribution:
Distribution Distribution
============ ============

4
src/V3LinkDot.cpp
View File

@ -1392,7 +1392,9 @@ private:
} }
virtual void visit(AstDefParam* nodep) override { virtual void visit(AstDefParam* nodep) override {
iterateChildren(nodep); iterateChildren(nodep);
nodep->v3warn(DEFPARAM, "Suggest replace defparam assignment with Verilog 2001 #(." nodep->v3warn(DEFPARAM, "defparam is deprecated (IEEE 1800-2017 C.4.1)\n"
<< nodep->warnMore()
<< "... Suggest use instantiation with #(."
<< nodep->prettyName() << "(...etc...))"); << nodep->prettyName() << "(...etc...))");
VSymEnt* foundp = m_statep->getNodeSym(nodep)->findIdFallback(nodep->path()); VSymEnt* foundp = m_statep->getNodeSym(nodep)->findIdFallback(nodep->path());
AstCell* cellp = foundp ? VN_CAST(foundp->nodep(), Cell) : nullptr; AstCell* cellp = foundp ? VN_CAST(foundp->nodep(), Cell) : nullptr;

3
test_regress/t/t_lint_defparam_bad.out
View File

@ -1,4 +1,5 @@
%Warning-DEFPARAM: t/t_lint_defparam.v:10:19: Suggest replace defparam assignment with Verilog 2001 #(.P(...etc...)) %Warning-DEFPARAM: t/t_lint_defparam.v:10:19: defparam is deprecated (IEEE 1800-2017 C.4.1)
: ... Suggest use instantiation with #(.P(...etc...))
10 | defparam sub.P = 2; 10 | defparam sub.P = 2;
| ^ | ^
... Use "/* verilator lint_off DEFPARAM */" and lint_on around source to disable this message. ... Use "/* verilator lint_off DEFPARAM */" and lint_on around source to disable this message.