From ba1f53a07076a8656dbe6e3886bf34a0be81ab5f Mon Sep 17 00:00:00 2001
From: Wilson Snyder <wsnyder@wsnyder.org>
Date: Sun, 14 Mar 2021 20:36:43 -0400
Subject: [PATCH] Improve DEFPARAM warning text.

---
 docs/xml.rst                           | 1 -
 src/V3LinkDot.cpp                      | 4 +++-
 test_regress/t/t_lint_defparam_bad.out | 3 ++-
 3 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/docs/xml.rst b/docs/xml.rst
index 6231c8273..a6aab1e0c 100644
--- a/docs/xml.rst
+++ b/docs/xml.rst
@@ -69,7 +69,6 @@ The XML document consists of 4 sections within the top level
    by elements in the ``<module>`` elements using the ``dtype_id``
    attribute.
 
-.. __distribution:
 
 Distribution
 ============
diff --git a/src/V3LinkDot.cpp b/src/V3LinkDot.cpp
index a9a3210b8..6bc5d26ea 100644
--- a/src/V3LinkDot.cpp
+++ b/src/V3LinkDot.cpp
@@ -1392,7 +1392,9 @@ private:
     }
     virtual void visit(AstDefParam* nodep) override {
         iterateChildren(nodep);
-        nodep->v3warn(DEFPARAM, "Suggest replace defparam assignment with Verilog 2001 #(."
+        nodep->v3warn(DEFPARAM, "defparam is deprecated (IEEE 1800-2017 C.4.1)\n"
+                                    << nodep->warnMore()
+                                    << "... Suggest use instantiation with #(."
                                     << nodep->prettyName() << "(...etc...))");
         VSymEnt* foundp = m_statep->getNodeSym(nodep)->findIdFallback(nodep->path());
         AstCell* cellp = foundp ? VN_CAST(foundp->nodep(), Cell) : nullptr;
diff --git a/test_regress/t/t_lint_defparam_bad.out b/test_regress/t/t_lint_defparam_bad.out
index f7093b05a..15a90af01 100644
--- a/test_regress/t/t_lint_defparam_bad.out
+++ b/test_regress/t/t_lint_defparam_bad.out
@@ -1,4 +1,5 @@
-%Warning-DEFPARAM: t/t_lint_defparam.v:10:19: Suggest replace defparam assignment with Verilog 2001 #(.P(...etc...))
+%Warning-DEFPARAM: t/t_lint_defparam.v:10:19: defparam is deprecated (IEEE 1800-2017 C.4.1)
+                                            : ... Suggest use instantiation with #(.P(...etc...))
    10 |    defparam sub.P = 2;
       |                   ^
                    ... Use "/* verilator lint_off DEFPARAM */" and lint_on around source to disable this message.