github/verilator
1
0
Fork 1
mirror of https://github.com/verilator/verilator.git synced 2025-04-04 19:52:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix mis-removing $value$plusargs calls (#5127) (#5137). [Seth Pellegrino]

Browse Source 
Co-authored-by: Seth Pellegrino <seth@codecopse.net>
This commit is contained in:
Wilson Snyder 2024-07-02 18:46:58 -04:00
parent 955ed3f193
commit a6d438d111
4 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
Changes
View File

@ -14,6 +14,7 @@ Verilator 5.027 devel
**Minor:** **Minor:**
* Fix fusing macro arguments to not ignore whitespace (#5061). [Tudor Timi] * Fix fusing macro arguments to not ignore whitespace (#5061). [Tudor Timi]
* Fix mis-removing $value$plusargs calls (#5127) (#5137). [Seth Pellegrino]
Verilator 5.026 2024-06-15 Verilator 5.026 2024-06-15

1
docs/CONTRIBUTORS
View File

@ -177,6 +177,7 @@ Samuel Riedel
Sean Cross Sean Cross
Sebastien Van Cauwenberghe Sebastien Van Cauwenberghe
Sergi Granell Sergi Granell
Seth Pellegrino
Srinivasan Venkataramanan Srinivasan Venkataramanan
Stefan Wallentowitz Stefan Wallentowitz
Stephen Henry Stephen Henry

2
src/V3Dead.cpp
View File

@ -311,7 +311,7 @@ class DeadVisitor final : public VNVisitor {
// still get deleted. // still get deleted.
} }
void visit(AstNode* nodep) override { void visit(AstNode* nodep) override {
if (nodep->isOutputter()) m_sideEffect = true; if (!m_sideEffect && !nodep->isPure()) m_sideEffect = true;
iterateChildren(nodep); iterateChildren(nodep);
checkAll(nodep); checkAll(nodep);
} }

9
test_regress/t/t_sys_plusargs.v
View File

@ -14,6 +14,7 @@ module t;
string sv_str; string sv_str;
reg [7*8:1] p_in; reg [7*8:1] p_in;
string sv_in; string sv_in;
integer unread; // never read
initial begin initial begin
if ($test$plusargs("PLUS")!==1) $stop; if ($test$plusargs("PLUS")!==1) $stop;
@ -119,6 +120,14 @@ module t;
if ($value$plusargs("INT=%d", p_i)) ; if ($value$plusargs("INT=%d", p_i)) ;
if (p_i !== 32'd1234) $stop; if (p_i !== 32'd1234) $stop;
// bug5127 - assign side effect test
p_i = 0;
p_r = 0;
unread = $value$plusargs("INT=%d", p_i);
unread = $value$plusargs("REAL=%e", p_r);
if (p_i !== 32'd1234) $stop;
if (p_r !== 1.2345) $stop;
$write("*-* All Finished *-*\n"); $write("*-* All Finished *-*\n");
$finish; $finish;
end end