Mario1159/verilator
1
0
Fork 0
forked from github/verilator
Code Pull Requests Releases 1 Activity

Fix internal error on initializing parameter array, bug1131.

Browse Source
This commit is contained in:
Wilson Snyder 2017-03-06 07:20:30 -05:00
parent c90960fc88
commit e637dd2390
4 changed files with 43 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Changes
View File

@ -13,6 +13,8 @@ The contributors that suggested a given feature are shown in []. Thanks!
**** Fix LDFLAGS and CFLAGS not preserving order, bug1130. [Olof Kindgren] **** Fix LDFLAGS and CFLAGS not preserving order, bug1130. [Olof Kindgren]
**** Fix internal error on initializing parameter array, bug1131. [Jie Xu]
* Verilator 3.900 2017-01-15 * Verilator 3.900 2017-01-15

2
src/V3Width.cpp
View File

@ -1283,7 +1283,7 @@ private:
AstNodeDType* vdtypep = m_vup->dtypep(); AstNodeDType* vdtypep = m_vup->dtypep();
if (!vdtypep) nodep->v3fatalSrc("InitArray type not assigned by AstPattern/Var visitor"); if (!vdtypep) nodep->v3fatalSrc("InitArray type not assigned by AstPattern/Var visitor");
nodep->dtypep(vdtypep); nodep->dtypep(vdtypep);
if (AstNodeArrayDType* arrayp = vdtypep->castNodeArrayDType()) { if (AstNodeArrayDType* arrayp = vdtypep->skipRefp()->castNodeArrayDType()) {
userIterateChildren(nodep, WidthVP(arrayp->subDTypep(),BOTH).p()); userIterateChildren(nodep, WidthVP(arrayp->subDTypep(),BOTH).p());
} else { } else {
nodep->v3fatalSrc("InitArray on non-array"); nodep->v3fatalSrc("InitArray on non-array");

14
test_regress/t/t_initarray_nonarray.pl Executable file
View File

@ -0,0 +1,14 @@
#!/usr/bin/perl
if (!$::Driver) { use FindBin; exec("$FindBin::Bin/bootstrap.pl", @ARGV, $0); die; }
# DESCRIPTION: Verilator: Verilog Test driver/expect definition
#
# Copyright 2003 by Wilson Snyder. This program is free software; you can
# redistribute it and/or modify it under the terms of either the GNU
# Lesser General Public License Version 3 or the Perl Artistic License
# Version 2.0.
compile (
);
ok(1);
1;

26
test_regress/t/t_initarray_nonarray.v Normal file
View File

@ -0,0 +1,26 @@
// DESCRIPTION: Verilator: Verilog Test module
//
// The code here is used to trigger Verilator internal error
// "InitArray on non-array"
//
// This file ONLY is placed into the Public Domain, for any use,
// without warranty, 2017 by Jie Xu.
typedef logic [7:0] mask_t [7:0];
// parameter logic [7:0] IMP_MASK[7:0] = '{8'hE1, 8'h03, 8'h07, 8'h3F, 8'h33, 8'hC3, 8'hC3, 8'h37};
parameter mask_t IMP_MASK = '{8'hE1, 8'h03, 8'h07, 8'h3F, 8'h33, 8'hC3, 8'hC3, 8'h37};
module t (/*AUTOARG*/
// Inputs
clk
);
input clk;
mask_t a;
//logic [7:0] a[7:0];
assign a = IMP_MASK;
endmodule