github/verilator
1
0
Fork 1
mirror of https://github.com/verilator/verilator.git synced 2025-05-03 14:06:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

Support foreach loops on strings (#3760)

Browse Source
This commit is contained in:
Ryszard Rozak 2022-11-18 13:07:56 +01:00 committed by GitHub
parent 749aab0a56
commit ef72b73a59
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 32 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/V3Width.cpp
View File

@ -4203,15 +4203,27 @@ private:
// Prep for next // Prep for next
fromDtp = fromDtp->subDTypep(); fromDtp = fromDtp->subDTypep();
} else if (AstBasicDType* const adtypep = VN_CAST(fromDtp, BasicDType)) { } else if (AstBasicDType* const adtypep = VN_CAST(fromDtp, BasicDType)) {
if (!adtypep->isRanged()) { if (adtypep->isString()) {
if (varp) {
AstConst* const leftp = new AstConst{fl, AstConst::Signed32{}, 0};
AstLt* const condp = new AstLt{fl, new AstVarRef{fl, varp, VAccess::READ},
new AstLenN{fl, fromp->cloneTree(false)}};
AstAdd* const incp
= new AstAdd{fl, new AstConst{fl, AstConst::Signed32{}, 1},
new AstVarRef{fl, varp, VAccess::READ}};
loopp = createForeachLoop(nodep, bodyPointp, varp, leftp, condp, incp);
}
} else if (!adtypep->isRanged()) {
argsp->v3error("Illegal to foreach loop on basic '" + fromDtp->prettyTypeName() argsp->v3error("Illegal to foreach loop on basic '" + fromDtp->prettyTypeName()
+ "'"); + "'");
VL_DO_DANGLING(nodep->unlinkFrBack()->deleteTree(), nodep); VL_DO_DANGLING(nodep->unlinkFrBack()->deleteTree(), nodep);
VL_DO_DANGLING(bodyPointp->deleteTree(), bodyPointp); VL_DO_DANGLING(bodyPointp->deleteTree(), bodyPointp);
return; return;
} } else {
if (varp) { if (varp) {
loopp = createForeachLoopRanged(nodep, bodyPointp, varp, adtypep->declRange()); loopp = createForeachLoopRanged(nodep, bodyPointp, varp,
adtypep->declRange());
}
} }
// Prep for next // Prep for next
fromDtp = nullptr; fromDtp = nullptr;

16
test_regress/t/t_foreach.v
View File

@ -18,6 +18,8 @@ module t (/*AUTOARG*/);
bit [31:0] depth1_array [0:0]; bit [31:0] depth1_array [0:0];
int oned [3:1]; int oned [3:1];
int twod [3:1][9:8]; int twod [3:1][9:8];
string str1;
string str2;
typedef struct packed { typedef struct packed {
reg [1:0] [63:0] subarray; reg [1:0] [63:0] subarray;
@ -150,6 +152,20 @@ module t (/*AUTOARG*/);
foreach (twod[i, j]); // Null body check foreach (twod[i, j]); // Null body check
str1 = "abcd";
str2 = "1234";
foreach (str1[i]) begin
str2[i] = str1[i];
end
if (str1 != str2) $stop;
str1 = "";
add = 0;
foreach(str1[i]) begin
add++;
end
`checkh(add, 0);
$write("*-* All Finished *-*\n"); $write("*-* All Finished *-*\n");
$finish; $finish;
end end