github/verilator
1
0
Fork 1
mirror of https://github.com/verilator/verilator.git synced 2025-04-05 04:02:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add increasing of stack size when possible (#5071) (#5104)

Browse Source
This commit is contained in:
Yinan Xu 2024-05-09 10:40:42 +08:00 committed by GitHub
parent ed01befc25
commit ce5cad17a8
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 38 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
include/verilated.cpp
View File

@ -3128,12 +3128,21 @@ void Verilated::stackCheck(QData needSize) VL_MT_UNSAFE {
if (haveSize == RLIM_INFINITY) haveSize = 0; if (haveSize == RLIM_INFINITY) haveSize = 0;
} }
// VL_PRINTF_MT("-Info: stackCheck(%" PRIu64 ") have %" PRIu64 "\n", needSize, haveSize); // VL_PRINTF_MT("-Info: stackCheck(%" PRIu64 ") have %" PRIu64 "\n", needSize, haveSize);
// Check for 1.5x need, but suggest 2x so small model increase won't cause warning // Check and request for 1.5x need. This is automated so the user doesn't need to do anything.
// if the user follows the suggestions QData requestSize = needSize + needSize / 2;
if (VL_UNLIKELY(haveSize && needSize && haveSize < (needSize + needSize / 2))) { if (VL_UNLIKELY(haveSize && needSize && haveSize < requestSize)) {
VL_PRINTF_MT("%%Warning: System has stack size %" PRIu64 " kb" // Try to increase the stack limit to the requested size
" which may be too small; suggest 'ulimit -s %" PRIu64 "' or larger\n", rlim.rlim_cur = requestSize;
haveSize / 1024, (needSize * 2) / 1024); if (
#ifdef _VL_TEST_RLIMIT_FAIL
true ||
#endif
setrlimit(RLIMIT_STACK, &rlim)) {
VL_PRINTF_MT("%%Warning: System has stack size %" PRIu64 " kb"
" which may be too small; failed to request more"
" using 'ulimit -s %" PRIu64 "'\n",
haveSize / 1024, requestSize);
}
} }
#else #else
(void)needSize; // Unused argument (void)needSize; // Unused argument

1
test_regress/t/t_stack_check.pl
View File

@ -16,6 +16,5 @@ compile(
execute(); execute();
file_grep($Self->{run_log_filename}, qr/.*%Warning: System has stack size/);
ok(1); ok(1);
1; 1;

23
test_regress/t/t_stack_check_fail.pl Executable file
View File

@ -0,0 +1,23 @@
#!/usr/bin/env perl
if (!$::Driver) { use FindBin; exec("$FindBin::Bin/bootstrap.pl", @ARGV, $0); die; }
# DESCRIPTION: Verilator: Verilog Test driver/expect definition
#
# Copyright 2003-2024 by Wilson Snyder. This program is free software; you
# can redistribute it and/or modify it under the terms of either the GNU
# Lesser General Public License Version 3 or the Perl Artistic License
# Version 2.0.
# SPDX-License-Identifier: LGPL-3.0-only OR Artistic-2.0
top_filename("t/t_stack_check.v");
scenarios(vlt => 1);
compile(
verilator_flags2 => ['--binary --debug-stack-check', '--CFLAGS', '"-D_VL_TEST_RLIMIT_FAIL"'],
);
execute();
file_grep($Self->{run_log_filename}, qr/.*%Warning: System has stack size/);
ok(1);
1;