github/verilator
1
0
Fork 1
mirror of https://github.com/verilator/verilator.git synced 2025-04-06 04:32:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

Support resizing function call inout arguments (#4467).

Browse Source
This commit is contained in:
Wilson Snyder 2023-09-17 18:23:44 -04:00
parent f507ee56b0
commit ab13548018
15 changed files with 408 additions and 134 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
Changes
View File

@ -13,6 +13,7 @@ Verilator 5.017 devel
**Minor:**
* Support resizing function call inout arguments (#4467).
Verilator 5.016 2023-09-16

15
src/V3AstNodeExpr.h
View File

@ -5083,6 +5083,21 @@ public:
bool sizeMattersLhs() const override { return false; }
int instrCount() const override { return 1 + V3Number::log2b(width()); }
};
class AstResizeLValue final : public AstNodeUniop {
// Resize a LValue into a wider/narrower entity at function argument boundry
// Width and signness is implied from nodep->width()
public:
AstResizeLValue(FileLine* fl, AstNodeExpr* lhsp)
: ASTGEN_SUPER_ResizeLValue(fl, lhsp) {}
ASTGEN_MEMBERS_AstResizeLValue;
void numberOperate(V3Number& out, const V3Number& lhs) override { V3ERROR_NA; }
string emitVerilog() override { return "%l"; }
string emitC() final override { V3ERROR_NA_RETURN(""); }
bool cleanOut() const override { return true; }
bool cleanLhs() const override { return true; }
bool sizeMattersLhs() const override { return false; }
int instrCount() const override { return 0; }
};
class AstSigned final : public AstNodeUniop {
// $signed(lhs)
public:

105
src/V3Task.cpp
View File

@ -412,6 +412,53 @@ private:
});
}
AstAssign* connectPortMakeInAssign(AstNodeExpr* pinp, AstVarScope* newvscp, bool pureCheck) {
// Create input assignment to go in FRONT of function call
AstNodeExpr* inPinp = pinp;
if (AstResizeLValue* sinPinp = VN_CAST(inPinp, ResizeLValue)) inPinp = sinPinp->lhsp();
AstNodeExpr* const inPinClonep
= pureCheck ? inPinp->cloneTreePure(true) : inPinp->cloneTree(true);
AstAssign* const assp = new AstAssign{
pinp->fileline(), new AstVarRef{newvscp->fileline(), newvscp, VAccess::WRITE},
inPinClonep};
assp->fileline()->modifyWarnOff(V3ErrorCode::BLKSEQ, true); // Ok if in <= block
return assp;
}
AstAssign* connectPortMakeOutAssign(AstVar* portp, AstNodeExpr* pinp, AstVarScope* newvscp,
bool pureCheck) {
// If needed, remap size of function to caller's output size
AstNodeExpr* outPinp = pinp;
AstNodeExpr* postRhsp = new AstVarRef{newvscp->fileline(), newvscp, VAccess::READ};
if (AstResizeLValue* soutPinp = VN_CAST(outPinp, ResizeLValue)) {
outPinp = soutPinp->lhsp();
if (AstNodeUniop* soutPinp = VN_CAST(outPinp, Extend)) {
outPinp = soutPinp->lhsp();
} else if (AstNodeUniop* soutPinp = VN_CAST(outPinp, ExtendS)) {
outPinp = soutPinp->lhsp();
} else if (AstSel* soutPinp = VN_CAST(outPinp, Sel)) {
outPinp = soutPinp->fromp();
} else {
outPinp->v3fatalSrc("Inout pin resizing should have had extend or select");
}
if (outPinp->width() < portp->width()) {
postRhsp = new AstSel{pinp->fileline(), postRhsp, 0, pinp->width()};
} else { // pin width > port width
if (pinp->isSigned() && postRhsp->isSigned()) {
postRhsp = new AstExtendS{pinp->fileline(), postRhsp};
} else {
postRhsp = new AstExtend{pinp->fileline(), postRhsp};
}
}
postRhsp->dtypeFrom(outPinp);
}
// Put output assignment AFTER function call
AstNodeExpr* const outPinClonep
= pureCheck ? outPinp->cloneTreePure(true) : outPinp->cloneTree(true);
AstAssign* const assp = new AstAssign{pinp->fileline(), outPinClonep, postRhsp};
assp->fileline()->modifyWarnOff(V3ErrorCode::BLKSEQ, true); // Ok if in <= block
return assp;
}
void connectPort(AstVar* portp, AstArg* argp, const string& namePrefix, AstNode* beginp,
bool inlineTask) {
AstNodeExpr* const pinp = argp->exprp();
@ -432,23 +479,31 @@ private:
pinp->v3error("Function/task " + portp->direction().prettyName() // e.g. "output"
+ " connected to constant instead of variable: "
+ portp->prettyNameQ());
} else if (portp->isInoutish()) {
// Correct lvalue; see comments below
}
// else if (portp->direction() == VDirection::REF) {
// TODO References need to instead pass a real reference var, see issue #3385
else if (portp->isInoutish()) {
// if (debug() >= 9) pinp->dumpTree("-pinrsize- ");
V3LinkLValue::linkLValueSet(pinp);
if (AstVarRef* const varrefp = VN_CAST(pinp, VarRef)) {
// Connect to this exact variable
if (inlineTask) {
AstVarScope* const localVscp = varrefp->varScopep();
UASSERT_OBJ(localVscp, varrefp, "Null var scope");
portp->user2p(localVscp);
pushDeletep(pinp);
}
} else {
pinp->v3warn(
E_TASKNSVAR,
"Unsupported: Function/task input argument is not simple variable");
AstVarScope* const newvscp
= createVarScope(portp, namePrefix + "__" + portp->shortName());
portp->user2p(newvscp);
if (!inlineTask)
pinp->replaceWith(
new AstVarRef{newvscp->fileline(), newvscp, VAccess::READWRITE});
// Put input assignment in FRONT of all other statements
AstAssign* const preassp = connectPortMakeInAssign(pinp, newvscp, true);
if (AstNode* const afterp = beginp->nextp()) {
afterp->unlinkFrBackWithNext();
AstNode::addNext<AstNode, AstNode>(preassp, afterp);
}
beginp->addNext(preassp);
AstAssign* const postassp = connectPortMakeOutAssign(portp, pinp, newvscp, true);
beginp->addNext(postassp);
// if (debug() >= 9) beginp->dumpTreeAndNext(cout, "-pinrsize-out- ");
} else if (portp->isWritable()) {
// Make output variables
// Correct lvalue; we didn't know when we linked
@ -463,29 +518,21 @@ private:
portp->user2p(newvscp);
if (!inlineTask)
pinp->replaceWith(new AstVarRef{newvscp->fileline(), newvscp, VAccess::WRITE});
AstAssign* const assp
= new AstAssign{pinp->fileline(), pinp,
new AstVarRef{newvscp->fileline(), newvscp, VAccess::READ}};
assp->fileline()->modifyWarnOff(V3ErrorCode::BLKSEQ,
true); // Ok if in <= block
AstAssign* const postassp = connectPortMakeOutAssign(portp, pinp, newvscp, false);
// Put assignment BEHIND of all other statements
beginp->addNext(assp);
beginp->addNext(postassp);
} else if (inlineTask && portp->isNonOutput()) {
// Make input variable
AstVarScope* const inVscp
AstVarScope* const newvscp
= createVarScope(portp, namePrefix + "__" + portp->shortName());
portp->user2p(inVscp);
AstAssign* const assp = new AstAssign{
pinp->fileline(), new AstVarRef{inVscp->fileline(), inVscp, VAccess::WRITE},
pinp};
assp->fileline()->modifyWarnOff(V3ErrorCode::BLKSEQ,
true); // Ok if in <= block
portp->user2p(newvscp);
AstAssign* const preassp = connectPortMakeInAssign(pinp, newvscp, false);
// Put assignment in FRONT of all other statements
if (AstNode* const afterp = beginp->nextp()) {
afterp->unlinkFrBackWithNext();
AstNode::addNext<AstNode, AstNode>(assp, afterp);
AstNode::addNext<AstNode, AstNode>(preassp, afterp);
}
beginp->addNext(assp);
beginp->addNext(preassp);
}
}
}

18
src/V3Width.cpp
View File

@ -5577,7 +5577,7 @@ private:
for (const auto& tconnect : tconnects) {
const AstVar* const portp = tconnect.first;
const AstArg* const argp = tconnect.second;
AstNode* const pinp = argp->exprp();
AstNodeExpr* const pinp = argp->exprp();
if (!pinp) continue; // Argument error we'll find later
AstNodeDType* const portDTypep = portp->dtypep()->skipRefToEnump();
const AstNodeDType* const pinDTypep = pinp->dtypep()->skipRefToEnump();
@ -5588,13 +5588,15 @@ private:
<< portDTypep->prettyDTypeName() << " but connection is "
<< pinDTypep->prettyDTypeName() << ".");
} else if (portp->isWritable() && pinp->width() != portp->width()) {
pinp->v3warn(E_UNSUPPORTED, "Unsupported: Function output argument "
<< portp->prettyNameQ() << " requires "
<< portp->width() << " bits, but connection's "
<< pinp->prettyTypeName() << " generates "
<< pinp->width() << " bits.");
// otherwise would need some mess to force both sides to proper size
// (get an ASSIGN with EXTEND on the lhs instead of rhs)
pinp->v3widthWarn(portp->width(), pinp->width(),
"Function output argument "
<< portp->prettyNameQ() << " requires " << portp->width()
<< " bits, but connection's " << pinp->prettyTypeName()
<< " generates " << pinp->width() << " bits.");
VNRelinker relinkHandle;
pinp->unlinkFrBack(&relinkHandle);
AstNodeExpr* const newp = new AstResizeLValue{pinp->fileline(), pinp};
relinkHandle.relink(newp);
}
if (!portp->basicp() || portp->basicp()->isOpaque()) {
checkClassAssign(nodep, "Function Argument", pinp, portDTypep);

7
test_regress/t/t_func_bad.out
View File

@ -10,11 +10,12 @@
: ... In instance t
11 | x;
| ^
%Error-UNSUPPORTED: t/t_func_bad.v:11:7: Unsupported: Function output argument 'y' requires 1 bits, but connection's CONST '?32?h0' generates 32 bits.
: ... In instance t
%Warning-WIDTHTRUNC: t/t_func_bad.v:11:7: Function output argument 'y' requires 1 bits, but connection's CONST '?32?h0' generates 32 bits.
: ... In instance t
11 | x;
| ^
... For error description see https://verilator.org/warn/UNSUPPORTED?v=latest
... For warning description see https://verilator.org/warn/WIDTHTRUNC?v=latest
... Use "/* verilator lint_off WIDTHTRUNC */" and lint_on around source to disable this message.
%Error: t/t_func_bad.v:14:17: No such argument 'no_such' in function call to FUNC 'f'
: ... In instance t
14 | f(.j(1), .no_such(2));

8
test_regress/t/t_func_tasknsvar_bad.out
View File

@ -1,8 +0,0 @@
%Error-TASKNSVAR: t/t_func_tasknsvar_bad.v:16:29: Unsupported: Function/task input argument is not simple variable
16 | foo(bus_we_select_from[2]);
| ^
... For error description see https://verilator.org/warn/TASKNSVAR?v=latest
%Error: Internal Error: t/t_func_tasknsvar_bad.v:10:7: ../V3Broken.cpp:#: Broken link in node (or something without maybePointedTo): 'm_varp && !m_varp->brokeExists()' @ ../V3AstNodes.cpp:#
10 | sig = '1;
| ^~~
... See the manual at https://verilator.org/verilator_doc.html for more assistance.

19
test_regress/t/t_func_tasknsvar_bad.v
View File

@ -1,19 +0,0 @@
// DESCRIPTION: Verilator: Test of select from constant
//
// This file ONLY is placed under the Creative Commons Public Domain, for
// any use, without warranty, 2020 by Wilson Snyder.
// SPDX-License-Identifier: CC0-1.0
module t (/*AUTOARG*/);
task foo(inout sig);
sig = '1;
endtask
reg [3:0] bus_we_select_from;
initial begin
foo(bus_we_select_from[2]); // Will get TASKNSVAR error
end
endmodule

12
test_regress/t/t_func_tasknsvar_bad.pl → test_regress/t/t_func_wide_out.pl
View File

@ -8,11 +8,15 @@ if (!$::Driver) { use FindBin; exec("$FindBin::Bin/bootstrap.pl", @ARGV, $0); di
# Version 2.0.
# SPDX-License-Identifier: LGPL-3.0-only OR Artistic-2.0
scenarios(vlt => 1);
scenarios(simulator => 1);
lint(
fails => 1,
expect_filename => $Self->{golden_filename},
compile(
verilator_flags2 => ["-Wno-WIDTHTRUNC"],
v_flags2 => ["+define+T_FUNC_WIDE_OUT t/t_func_wide_out_c.cpp"],
);
execute(
check_finished => 1,
);
ok(1);

125
test_regress/t/t_func_wide_out.v Normal file
View File

@ -0,0 +1,125 @@
// DESCRIPTION: Verilator: Verilog Test module
//
// This file ONLY is placed under the Creative Commons Public Domain, for
// any use, without warranty, 2023 by Wilson Snyder.
// SPDX-License-Identifier: CC0-1.0
`define stop $stop
`define checkh(gotv,expv) do if ((gotv) !== (expv)) begin $write("%%Error: %s:%0d: got='h%x exp='h%x\n", `__FILE__,`__LINE__, (gotv), (expv)); `stop; end while(0);
typedef bit signed [11:0] s12_t;
typedef bit unsigned [11:0] u12_t;
typedef bit signed [69:0] s70_t;
typedef bit unsigned [69:0] u70_t;
import "DPI-C" context function void dpii_inv_s12(input s12_t in, output s12_t out);
import "DPI-C" context function void dpii_inv_u12(input u12_t in, output u12_t out);
import "DPI-C" context function void dpii_inv_s70(input s70_t in, output s70_t out);
import "DPI-C" context function void dpii_inv_u70(input s70_t in, output u70_t out);
class Cls #(type T = bit);
static function void get(inout T value);
`ifdef TEST_NOINLINE
// verilator no_inline_task
`endif
value = ~value;
endfunction
endclass
module t;
parameter MSG_PORT_WIDTH = 4350;
localparam PAYLOAD_MAX_BITS = 4352;
reg [MSG_PORT_WIDTH-1:0] msg;
function void func (output bit [PAYLOAD_MAX_BITS-1:0] data);
`ifdef TEST_NOINLINE
// verilator no_inline_task
`endif
data = {PAYLOAD_MAX_BITS{1'b1}};
endfunction
s12_t ds12;
u12_t du12;
s70_t ds70;
u70_t du70;
s12_t qs12;
u12_t qu12;
s70_t qs70;
u70_t qu70;
initial begin
// Operator TASKREF 'func' expects 4352 bits on the Function Argument, but Function Argument's VARREF 'msg' generates 4350 bits.
// verilator lint_off WIDTHEXPAND
func(msg);
if (msg !== {MSG_PORT_WIDTH{1'b1}}) $stop;
begin
// narrow connect to wide
ds12 = 12'h234;
Cls#(s70_t)::get(ds12);
`checkh(ds12, 12'hdcb);
ds12 = 12'he34; // negative if signed
Cls#(s70_t)::get(ds12);
`checkh(ds12, 12'h1cb);
du12 = 12'h244;
Cls#(u70_t)::get(du12);
`checkh(du12, 12'hdbb);
du12 = 12'he34; // negative if signed
Cls#(u70_t)::get(du12);
`checkh(du12, 12'h1cb);
// wie connect to narrow
ds70 = 12'h254;
Cls#(s12_t)::get(ds70);
`checkh(ds70, 70'h3ffffffffffffffdab);
ds70 = 12'he34; // negative if signed
Cls#(s12_t)::get(ds70);
`checkh(ds70, 70'h0000000000000001cb);
du70 = 12'h264;
Cls#(u12_t)::get(du70);
`checkh(du70, 70'h000000000000000d9b);
du70 = 12'he34; // negative if signed
Cls#(u12_t)::get(du70);
`checkh(du70, 70'h0000000000000001cb);
end
begin
// narrow connect to wide
ds12 = 12'h234;
dpii_inv_s70(ds12, qs12);
`checkh(qs12, 12'hdcb);
ds12 = 12'he34; // negative if signed
dpii_inv_s70(ds12, qs12);
`checkh(qs12, 12'h1cb);
du12 = 12'h244;
dpii_inv_u70(du12, qu12);
`checkh(qu12, 12'hdbb);
du12 = 12'he34; // negative if signed
dpii_inv_u70(ds12, qs12);
`checkh(qs12, 12'h1cb);
// wie connect to narrow
ds70 = 12'h254;
dpii_inv_s12(ds70, qs70);
`checkh(qs70, 70'h3ffffffffffffffdab);
ds70 = 12'he34; // negative if signed
dpii_inv_s12(ds70, qs70);
`checkh(qs70, 70'h0000000000000001cb);
du70 = 12'h264;
dpii_inv_u12(du70, qu70);
`checkh(qu70, 70'h000000000000000d9b);
du70 = 12'he34; // negative if signed
dpii_inv_u12(du70, qu70);
`checkh(qu70, 70'h0000000000000001cb);
end
$write("*-* All Finished *-*\n");
$finish;
end
endmodule

87
test_regress/t/t_func_wide_out_bad.out
View File

@ -1,6 +1,83 @@
%Error-UNSUPPORTED: t/t_func_wide_out_bad.v:17:12: Unsupported: Function output argument 'data' requires 4352 bits, but connection's VARREF 'msg' generates 4350 bits.
: ... In instance t
17 | func(msg);
| ^~~
... For error description see https://verilator.org/warn/UNSUPPORTED?v=latest
%Warning-WIDTHTRUNC: t/t_func_wide_out.v:76:27: Function output argument 'value' requires 12 bits, but connection's VARREF 'ds70' generates 70 bits.
: ... In instance t
76 | Cls#(s12_t)::get(ds70);
| ^~~~
... For warning description see https://verilator.org/warn/WIDTHTRUNC?v=latest
... Use "/* verilator lint_off WIDTHTRUNC */" and lint_on around source to disable this message.
%Warning-WIDTHTRUNC: t/t_func_wide_out.v:76:23: Operator TASKREF 'get' expects 12 bits on the Function Argument, but Function Argument's VARREF 'ds70' generates 70 bits.
: ... In instance t
76 | Cls#(s12_t)::get(ds70);
| ^~~
%Warning-WIDTHTRUNC: t/t_func_wide_out.v:79:27: Function output argument 'value' requires 12 bits, but connection's VARREF 'ds70' generates 70 bits.
: ... In instance t
79 | Cls#(s12_t)::get(ds70);
| ^~~~
%Warning-WIDTHTRUNC: t/t_func_wide_out.v:79:23: Operator TASKREF 'get' expects 12 bits on the Function Argument, but Function Argument's VARREF 'ds70' generates 70 bits.
: ... In instance t
79 | Cls#(s12_t)::get(ds70);
| ^~~
%Warning-WIDTHTRUNC: t/t_func_wide_out.v:83:27: Function output argument 'value' requires 12 bits, but connection's VARREF 'du70' generates 70 bits.
: ... In instance t
83 | Cls#(u12_t)::get(du70);
| ^~~~
%Warning-WIDTHTRUNC: t/t_func_wide_out.v:83:23: Operator TASKREF 'get' expects 12 bits on the Function Argument, but Function Argument's VARREF 'du70' generates 70 bits.
: ... In instance t
83 | Cls#(u12_t)::get(du70);
| ^~~
%Warning-WIDTHTRUNC: t/t_func_wide_out.v:86:27: Function output argument 'value' requires 12 bits, but connection's VARREF 'du70' generates 70 bits.
: ... In instance t
86 | Cls#(u12_t)::get(du70);
| ^~~~
%Warning-WIDTHTRUNC: t/t_func_wide_out.v:86:23: Operator TASKREF 'get' expects 12 bits on the Function Argument, but Function Argument's VARREF 'du70' generates 70 bits.
: ... In instance t
86 | Cls#(u12_t)::get(du70);
| ^~~
%Warning-WIDTHTRUNC: t/t_func_wide_out.v:108:10: Operator TASKREF 'dpii_inv_s12' expects 12 bits on the Function Argument, but Function Argument's VARREF 'ds70' generates 70 bits.
: ... In instance t
108 | dpii_inv_s12(ds70, qs70);
| ^~~~~~~~~~~~
%Warning-WIDTHTRUNC: t/t_func_wide_out.v:108:29: Function output argument 'out' requires 12 bits, but connection's VARREF 'qs70' generates 70 bits.
: ... In instance t
108 | dpii_inv_s12(ds70, qs70);
| ^~~~
%Warning-WIDTHTRUNC: t/t_func_wide_out.v:108:10: Operator TASKREF 'dpii_inv_s12' expects 12 bits on the Function Argument, but Function Argument's VARREF 'qs70' generates 70 bits.
: ... In instance t
108 | dpii_inv_s12(ds70, qs70);
| ^~~~~~~~~~~~
%Warning-WIDTHTRUNC: t/t_func_wide_out.v:111:10: Operator TASKREF 'dpii_inv_s12' expects 12 bits on the Function Argument, but Function Argument's VARREF 'ds70' generates 70 bits.
: ... In instance t
111 | dpii_inv_s12(ds70, qs70);
| ^~~~~~~~~~~~
%Warning-WIDTHTRUNC: t/t_func_wide_out.v:111:29: Function output argument 'out' requires 12 bits, but connection's VARREF 'qs70' generates 70 bits.
: ... In instance t
111 | dpii_inv_s12(ds70, qs70);
| ^~~~
%Warning-WIDTHTRUNC: t/t_func_wide_out.v:111:10: Operator TASKREF 'dpii_inv_s12' expects 12 bits on the Function Argument, but Function Argument's VARREF 'qs70' generates 70 bits.
: ... In instance t
111 | dpii_inv_s12(ds70, qs70);
| ^~~~~~~~~~~~
%Warning-WIDTHTRUNC: t/t_func_wide_out.v:115:10: Operator TASKREF 'dpii_inv_u12' expects 12 bits on the Function Argument, but Function Argument's VARREF 'du70' generates 70 bits.
: ... In instance t
115 | dpii_inv_u12(du70, qu70);
| ^~~~~~~~~~~~
%Warning-WIDTHTRUNC: t/t_func_wide_out.v:115:29: Function output argument 'out' requires 12 bits, but connection's VARREF 'qu70' generates 70 bits.
: ... In instance t
115 | dpii_inv_u12(du70, qu70);
| ^~~~
%Warning-WIDTHTRUNC: t/t_func_wide_out.v:115:10: Operator TASKREF 'dpii_inv_u12' expects 12 bits on the Function Argument, but Function Argument's VARREF 'qu70' generates 70 bits.
: ... In instance t
115 | dpii_inv_u12(du70, qu70);
| ^~~~~~~~~~~~
%Warning-WIDTHTRUNC: t/t_func_wide_out.v:118:10: Operator TASKREF 'dpii_inv_u12' expects 12 bits on the Function Argument, but Function Argument's VARREF 'du70' generates 70 bits.
: ... In instance t
118 | dpii_inv_u12(du70, qu70);
| ^~~~~~~~~~~~
%Warning-WIDTHTRUNC: t/t_func_wide_out.v:118:29: Function output argument 'out' requires 12 bits, but connection's VARREF 'qu70' generates 70 bits.
: ... In instance t
118 | dpii_inv_u12(du70, qu70);
| ^~~~
%Warning-WIDTHTRUNC: t/t_func_wide_out.v:118:10: Operator TASKREF 'dpii_inv_u12' expects 12 bits on the Function Argument, but Function Argument's VARREF 'qu70' generates 70 bits.
: ... In instance t
118 | dpii_inv_u12(du70, qu70);
| ^~~~~~~~~~~~
%Error: Exiting due to

4
test_regress/t/t_func_wide_out_bad.pl
View File

@ -8,7 +8,9 @@ if (!$::Driver) { use FindBin; exec("$FindBin::Bin/bootstrap.pl", @ARGV, $0); di
# Version 2.0.
# SPDX-License-Identifier: LGPL-3.0-only OR Artistic-2.0
scenarios(linter => 1);
scenarios(vlt => 1);
top_filename("t/t_func_wide_out.v");
lint(
fails => 1,

30
test_regress/t/t_func_wide_out_bad.v
View File

@ -1,30 +0,0 @@
// DESCRIPTION: Verilator: Verilog Test module
//
// This file ONLY is placed under the Creative Commons Public Domain, for
// any use, without warranty, 2003 by Wilson Snyder.
// SPDX-License-Identifier: CC0-1.0
module t ();
parameter MSG_PORT_WIDTH = 4350;
localparam PAYLOAD_MAX_BITS = 4352;
reg [MSG_PORT_WIDTH-1:0] msg;
initial begin
// Operator TASKREF 'func' expects 4352 bits on the Function Argument, but Function Argument's VARREF 'msg' generates 4350 bits.
// verilator lint_off WIDTH
func(msg);
// verilator lint_on WIDTH
if (msg !== {MSG_PORT_WIDTH{1'b1}}) $stop;
$write("*-* All Finished *-*\n");
$finish;
end
function integer func (output bit [PAYLOAD_MAX_BITS-1:0] data);
/*verilator no_inline_task*/
data = {PAYLOAD_MAX_BITS{1'b1}};
return 1;
endfunction
endmodule

46
test_regress/t/t_func_wide_out_c.cpp Normal file
View File

@ -0,0 +1,46 @@
// -*- mode: C++; c-file-style: "cc-mode" -*-
//*************************************************************************
//
// Copyright 2009-2009 by Wilson Snyder. This program is free software; you can
// redistribute it and/or modify it under the terms of either the GNU
// Lesser General Public License Version 3 or the Perl Artistic License
// Version 2.0.
// SPDX-License-Identifier: LGPL-3.0-only OR Artistic-2.0
//
//*************************************************************************
#include "svdpi.h"
#include <cstdio>
#include <cstring>
//======================================================================
// clang-format off
#if defined(VERILATOR)
# ifdef T_FUNC_WIDE_OUT
# include "Vt_func_wide_out__Dpi.h"
# elif defined(T_FUNC_WIDE_OUT_NOINL)
# include "Vt_func_wide_out_noinl__Dpi.h"
# else
# error "Unknown test"
# endif
#elif defined(VCS)
# include "../vc_hdrs.h"
#else
# error "Unknown simulator for DPI test"
#endif
// clang-format on
//======================================================================
void dpii_inv_s12(const svBitVecVal* in, svBitVecVal* out) { out[0] = ~in[0]; }
void dpii_inv_u12(const svBitVecVal* in, svBitVecVal* out) { out[0] = ~in[0]; }
void dpii_inv_s70(const svBitVecVal* in, svBitVecVal* out) {
out[0] = ~in[0];
out[1] = ~in[1] & 0xf;
}
void dpii_inv_u70(const svBitVecVal* in, svBitVecVal* out) {
out[0] = ~in[0];
out[1] = ~in[1] & 0xf;
}

25
test_regress/t/t_func_wide_out_noinl.pl Executable file
View File

@ -0,0 +1,25 @@
#!/usr/bin/env perl
if (!$::Driver) { use FindBin; exec("$FindBin::Bin/bootstrap.pl", @ARGV, $0); die; }
# DESCRIPTION: Verilator: Verilog Test driver/expect definition
#
# Copyright 2003 by Wilson Snyder. This program is free software; you
# can redistribute it and/or modify it under the terms of either the GNU
# Lesser General Public License Version 3 or the Perl Artistic License
# Version 2.0.
# SPDX-License-Identifier: LGPL-3.0-only OR Artistic-2.0
scenarios(simulator => 1);
top_filename("t_func_wide_out.v");
compile(
verilator_flags2 => ["-Wno-WIDTHTRUNC"],
v_flags2 => ["+define+T_FUNC_WIDE_OUT_NOINL +define+TEST_NOINLINE t/t_func_wide_out_c.cpp"],
);
execute(
check_finished => 1,
);
ok(1);
1;

40
test_regress/t/t_uvm_pkg_todo.vh
View File

@ -13464,10 +13464,8 @@ function uvm_component::new (string name, uvm_component parent);
event_pool = new("event_pool");
m_domain = parent.m_domain;
reseed();
//TODO issue #4467 - Fix UVM function output width reassignment
//TODO %Error-UNSUPPORTED: t/t_uvm_pkg_todo.vh:13463:76: Unsupported: Function output argument 'value' requires 4096 bits, but connection's VARREF 'recording_detail' generates 32 bits.
//TODO if (!uvm_config_db #(uvm_bitstream_t)::get(this, "", "recording_detail", recording_detail))
//TODO void'(uvm_config_db #(int)::get(this, "", "recording_detail", recording_detail));
if (!uvm_config_db #(uvm_bitstream_t)::get(this, "", "recording_detail", recording_detail))
void'(uvm_config_db #(int)::get(this, "", "recording_detail", recording_detail));
m_rh.set_name(get_full_name());
set_report_verbosity_level(parent.get_report_verbosity_level());
m_set_cl_msg_args();
@ -15876,10 +15874,8 @@ virtual class uvm_port_base #(type IF=uvm_void) extends IF;
m_min_size = min_size;
m_max_size = max_size;
m_comp = new(name, parent, this);
//TODO issue #4467 - Fix UVM function output width reassignment
//TODO %Error-UNSUPPORTED: t/t_uvm_pkg_todo.vh:15875:75: Unsupported: Function output argument 'value' requires 4096 bits, but connection's VARREF 'tmp' generates 32 bits.
//TODO if (!uvm_config_int::get(m_comp, "", "check_connection_relationships",tmp))
//TODO m_comp.set_report_id_action(s_connection_warning_id, UVM_NO_ACTION);
if (!uvm_config_int::get(m_comp, "", "check_connection_relationships",tmp))
m_comp.set_report_id_action(s_connection_warning_id, UVM_NO_ACTION);
endfunction
function string get_name();
return m_comp.get_name();
@ -26304,17 +26300,13 @@ function uvm_status_e uvm_reg::backdoor_read_func(uvm_reg_item rw);
uvm_report_info ("RegMem", $sformatf("backdoor_read from %s ", hdl_concat.slices[j].path), UVM_DEBUG, "t/uvm/src/reg/uvm_reg.svh", 2192, "", 1);
end
if (hdl_concat.slices[j].offset < 0) begin
//TODO issue #4467 - Fix UVM function output width reassignment
//TODO %Error-UNSUPPORTED: t/t_uvm_pkg_todo.vh:26297:57: Unsupported: Function output argument 'value' requires 1024 bits, but connection's VARREF 'val' generates 64 bits.
//TODO ok &= uvm_hdl_read(hdl_concat.slices[j].path,val);
ok &= uvm_hdl_read(hdl_concat.slices[j].path,val);
continue;
end
begin
uvm_reg_data_t slice;
int k = hdl_concat.slices[j].offset;
//TODO issue #4467 - Fix UVM function output width reassignment
//TODO %Error-UNSUPPORTED: t/t_uvm_pkg_todo.vh:26303:58: Unsupported: Function output argument 'value' requires 1024 bits, but connection's VARREF 'slice' generates 64 bits.
//TODO ok &= uvm_hdl_read(hdl_concat.slices[j].path, slice);
ok &= uvm_hdl_read(hdl_concat.slices[j].path, slice);
repeat (hdl_concat.slices[j].size) begin
val[k++] = slice[0];
slice >>= 1;
@ -29572,17 +29564,13 @@ function uvm_status_e uvm_mem::backdoor_read_func(uvm_reg_item rw);
uvm_report_info ("RegModel", {"backdoor_read from ",hdl_path}, UVM_DEBUG, "t/uvm/src/reg/uvm_mem.svh", 1691, "", 1);
end
if (hdl_concat.slices[j].offset < 0) begin
//TODO issue #4467 - Fix UVM function output width reassignment
//TODO %Error-UNSUPPORTED: t/t_uvm_pkg_todo.vh:29567:44: Unsupported: Function output argument 'value' requires 1024 bits, but connection's VARREF 'slice' generates 64 bits.
//TODO ok &= uvm_hdl_read(hdl_path, val);
ok &= uvm_hdl_read(hdl_path, val);
continue;
end
begin
uvm_reg_data_t slice;
int k = hdl_concat.slices[j].offset;
//TODO issue #4467 - Fix UVM function output width reassignment
//TODO %Error-UNSUPPORTED: t/t_uvm_pkg_todo.vh:34181:38: Unsupported: Function output argument 'value' requires 1024 bits, but connection's VARREF 'd' generates 64 bits.
//TODO ok &= uvm_hdl_read(hdl_path, slice);
ok &= uvm_hdl_read(hdl_path, slice);
repeat (hdl_concat.slices[j].size) begin
val[k++] = slice[0];
slice >>= 1;
@ -34196,13 +34184,11 @@ endfunction : __m_uvm_execute_field_op
foreach (path.slices[j]) begin
string p_ = path.slices[j].path;
uvm_reg_data_t d;
//TODO issue #4467 - Fix UVM function output width reassignment
//TODO %Error: t/t_uvm_pkg_todo.vh:19861:21: Function Argument expects a CLASSREFDTYPE 'uvm_sequencer__Tz97_TBz97', got CLASSREFDTYPE 'uvm_sequencer__Tz97'
//TODO if (!uvm_hdl_read(p_,d))
//TODO begin
//TODO if (uvm_report_enabled(UVM_NONE,UVM_ERROR,"uvm_reg_mem_hdl_paths_seq"))
//TODO uvm_report_error ("uvm_reg_mem_hdl_paths_seq", $sformatf("HDL path \"%s\" for register \"%s\" is not readable", p_, r.get_full_name()), UVM_NONE, "t/uvm/src/reg/sequences/uvm_reg_mem_hdl_paths_seq.svh", 145, "", 1);
//TODO end
if (!uvm_hdl_read(p_,d))
begin
if (uvm_report_enabled(UVM_NONE,UVM_ERROR,"uvm_reg_mem_hdl_paths_seq"))
uvm_report_error ("uvm_reg_mem_hdl_paths_seq", $sformatf("HDL path \"%s\" for register \"%s\" is not readable", p_, r.get_full_name()), UVM_NONE, "t/uvm/src/reg/sequences/uvm_reg_mem_hdl_paths_seq.svh", 145, "", 1);
end
if (!uvm_hdl_check_path(p_))
begin
if (uvm_report_enabled(UVM_NONE,UVM_ERROR,"uvm_reg_mem_hdl_paths_seq"))