Fix error on enum with VARHIDDEN of cell (#4482).

Changes

@@ -31,6 +31,7 @@ Verilator 5.015 devel
 * Fix false MULTITOP on bound interfaces (#4438). [Alex Solomatnikov]
 * Fix internal error on real conversion (#4447). [vdhotre-ventana]
 * Fix lifetime unknown error on enum.name (#4448). [jwoutersymatra]
+* Fix error on enum with VARHIDDEN of cell (#4482). [Michail Rontionov]
 * Fix display %x formatting of real.
 * Fix mis-warning on #() in classes' own functions.
 

src/V3LinkDot.cpp

@@ -1351,7 +1351,7 @@ class LinkDotFindVisitor final : public VNVisitor {
         if (!foundp && m_modSymp && nodep->name() == m_modSymp->nodep()->name()) {
             foundp = m_modSymp;  // Conflicts with modname?
         }
-        AstEnumItem* const findvarp = foundp ? VN_AS(foundp->nodep(), EnumItem) : nullptr;
+        AstEnumItem* const findvarp = foundp ? VN_CAST(foundp->nodep(), EnumItem) : nullptr;
         bool ins = false;
         if (!foundp) {
             ins = true;
@@ -1375,7 +1375,7 @@ class LinkDotFindVisitor final : public VNVisitor {
                                       << nodep->warnContextPrimary() << '\n'
                                       << foundp->nodep()->warnOther()
                                       << "... Location of original declaration\n"
-                                      << nodep->warnContextSecondary());
+                                      << foundp->nodep()->warnContextSecondary());
                 }
                 ins = true;
             }

test_regress/t/t_enum_bad_cell.out

@@ -0,0 +1,9 @@
+%Warning-VARHIDDEN: t/t_enum_bad_cell.v:12:14: Declaration of enum value hides declaration in upper scope: s1
+   12 |    enum {s0, s1} state;
+      |              ^~
+                    t/t_enum_bad_cell.v:8:8: ... Location of original declaration
+    8 |    sub s1();
+      |        ^~
+                    ... For warning description see https://verilator.org/warn/VARHIDDEN?v=latest
+                    ... Use "/* verilator lint_off VARHIDDEN */" and lint_on around source to disable this message.
+%Error: Exiting due to

test_regress/t/t_enum_bad_cell.pl

@@ -0,0 +1,20 @@
+#!/usr/bin/env perl
+if (!$::Driver) { use FindBin; exec("$FindBin::Bin/bootstrap.pl", @ARGV, $0); die; }
+# DESCRIPTION: Verilator: Verilog Test driver/expect definition
+#
+# Copyright 2003 by Wilson Snyder. This program is free software; you
+# can redistribute it and/or modify it under the terms of either the GNU
+# Lesser General Public License Version 3 or the Perl Artistic License
+# Version 2.0.
+# SPDX-License-Identifier: LGPL-3.0-only OR Artistic-2.0
+
+scenarios(linter => 1);
+
+lint(
+    verilator_flags2 => ["--lint-only -Wwarn-VARHIDDEN"],
+    fails => 1,
+    expect_filename => $Self->{golden_filename},
+    );
+
+ok(1);
+1;

test_regress/t/t_enum_bad_cell.v

@@ -0,0 +1,17 @@
+// DESCRIPTION: Verilator: Verilog Test module
+//
+// This file ONLY is placed under the Creative Commons Public Domain, for
+// any use, without warranty, 2023 by Wilson Snyder.
+// SPDX-License-Identifier: CC0-1.0
+
+module t (/*AUTOARG*/);
+   sub s1();
+endmodule
+
+module sub (/*AUTOARG*/);
+   enum {s0, s1} state;
+   initial begin
+      $write("*-* All Finished *-*\n");
+      $finish;
+   end
+endmodule

test_regress/t/t_enum_bad_hide.out

@@ -2,8 +2,8 @@
    11 |    typedef enum { HIDE_VALUE = 0 } hide_enum_t;
       |                   ^~~~~~~~~~
                     t/t_enum_bad_hide.v:7:16: ... Location of original declaration
-   11 |    typedef enum { HIDE_VALUE = 0 } hide_enum_t;
-      |                   ^~~~~~~~~~
+    7 | typedef enum { HIDE_VALUE = 0 } hide_enum_t;
+      |                ^~~~~~~~~~
                     ... For warning description see https://verilator.org/warn/VARHIDDEN?v=latest
                     ... Use "/* verilator lint_off VARHIDDEN */" and lint_on around source to disable this message.
 %Error: Exiting due to