github/verilator
1
0
Fork 1
mirror of https://github.com/verilator/verilator.git synced 2025-04-04 19:52:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix isPure to be superset of isOutputter.

Browse Source 
This may cause some additional SIDEEFFECT warnings that previously were not shown.
This commit is contained in:
Wilson Snyder 2024-06-16 21:43:30 -04:00
parent d5cfe1a379
commit 607c19a67d
5 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/V3Ast.cpp
View File

@ -801,7 +801,6 @@ AstNode* AstNode::cloneTreeIter(bool needPure) {
<< this->warnMore()
<< "... Suggest use a temporary variable in place of this expression");
// this->v3fatalSrc("cloneTreePure debug backtrace"); // Comment in to debug where caused
// it
}
AstNode* const newp = this->clone();
if (this->m_op1p) newp->op1p(this->m_op1p->cloneTreeIterList(needPure));

4
src/V3AstNodeOther.h
View File

@ -2786,7 +2786,7 @@ public:
bool isGateOptimizable() const override { return false; }
bool isPredictOptimizable() const override { return false; }
bool isOutputter() override { return true; }
// but isPure() true
bool isPure() override { return false; }
AstCoverDecl* declp() const { return m_declp; } // Where defined
};
class AstCoverToggle final : public AstNodeStmt {
@ -3379,7 +3379,7 @@ public:
bool isGateOptimizable() const override { return false; }
bool isPredictOptimizable() const override { return false; }
bool isOutputter() override { return true; }
// but isPure() true
bool isPure() override { return false; }
AstTraceDecl* declp() const { return m_declp; }
VTraceType traceType() const { return m_traceType; }
uint32_t baseCode() const { return m_baseCode; }

2
test_regress/t/t_interface_array2.v
View File

@ -36,9 +36,11 @@ module t
assign ifs[i].logic_in_intf = data[i];
end
endgenerate
// verilator lint_off SIDEEFFECT
modify_interface m3 (
.value(data[return_3()]),
.intf_inst(ifs[return_3()]));
// verilator lint_on SIDEEFFECT
modify_interface m4 (
.value(data[4]),

4
test_regress/t/t_wrapper_context_top0.out
View File

@ -71,9 +71,9 @@ C 'ft/t_wrapper_context.vl22n4pagev_line/topoblockS22,25-29htop0.t
C 'ft/t_wrapper_context.vl32n4pagev_line/topoblockS32htop0.top' 11
C 'ft/t_wrapper_context.vl33n7pagev_branch/topoifS33-34htop0.top' 1
C 'ft/t_wrapper_context.vl33n8pagev_branch/topoelseS36htop0.top' 10
C 'ft/t_wrapper_context.vl38n4pagev_line/topoblockS38-39htop0.top' 1
C 'ft/t_wrapper_context.vl38n4pagev_line/topoblockS38-39htop0.top' 34
C 'ft/t_wrapper_context.vl40n7pagev_branch/topoifS40htop0.top' 0
C 'ft/t_wrapper_context.vl40n8pagev_branch/topoelseS46htop0.top' 23
C 'ft/t_wrapper_context.vl40n8pagev_branch/topoelseS46htop0.top' 34
C 'ft/t_wrapper_context.vl41n11pagev_line/topoelsehtop0.top' 0
C 'ft/t_wrapper_context.vl47n10pagev_branch/topoifS47-49htop0.top' 1
C 'ft/t_wrapper_context.vl47n11pagev_branch/topoelsehtop0.top' 33

4
test_regress/t/t_wrapper_context_top1.out
View File

@ -71,8 +71,8 @@ C 'ft/t_wrapper_context.vl22n4pagev_line/topoblockS22,25-29htop1.t
C 'ft/t_wrapper_context.vl32n4pagev_line/topoblockS32htop1.top' 6
C 'ft/t_wrapper_context.vl33n7pagev_branch/topoifS33-34htop1.top' 1
C 'ft/t_wrapper_context.vl33n8pagev_branch/topoelseS36htop1.top' 5
C 'ft/t_wrapper_context.vl38n4pagev_line/topoblockS38-39htop1.top' 1
C 'ft/t_wrapper_context.vl40n7pagev_branch/topoifS40htop1.top' 13
C 'ft/t_wrapper_context.vl38n4pagev_line/topoblockS38-39htop1.top' 19
C 'ft/t_wrapper_context.vl40n7pagev_branch/topoifS40htop1.top' 19
C 'ft/t_wrapper_context.vl40n8pagev_branch/topoelseS46htop1.top' 0
C 'ft/t_wrapper_context.vl41n11pagev_line/topoelsehtop1.top' 18
C 'ft/t_wrapper_context.vl47n10pagev_branch/topoifS47-49htop1.top' 0