github/verilator
1
0
Fork 1
mirror of https://github.com/verilator/verilator.git synced 2025-04-05 04:02:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

Internals: Fix memory leak in V3FileLine (#3407) (#3408). No functional change intended.

Browse Source
This commit is contained in:
HungMingWu 2022-05-15 06:15:38 +08:00 committed by GitHub
parent c2328ef46a
commit 560efb2c9e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/V3FileLine.cpp
View File

@ -155,7 +155,7 @@ FileLine::FileLine(FileLine::EmptySecret) {
}
void FileLine::newContent() {
m_contentp = new VFileContent;
m_contentp = std::make_shared<VFileContent>();
m_contentLineno = 1;
}

5
src/V3FileLine.h
View File

@ -26,6 +26,7 @@
#include <sstream>
#include <bitset>
#include <map>
#include <memory>
#include <set>
#include <deque>
@ -97,7 +98,7 @@ class FileLine final {
int m_lastColumn = 0; // `line corrected token's last column number
int m_filenameno; // `line corrected filename number
int m_contentLineno = 0; // Line number within source stream
VFileContent* m_contentp = nullptr; // Source text contents line is within
std::shared_ptr<VFileContent> m_contentp = nullptr; // Source text contents line is within
FileLine* m_parent = nullptr; // Parent line that included this line
std::bitset<V3ErrorCode::_ENUM_MAX> m_warnOn;
bool m_waive = false; // Waive warning
@ -180,7 +181,7 @@ public:
int firstColumn() const { return m_firstColumn; }
int lastLineno() const { return m_lastLineno; }
int lastColumn() const { return m_lastColumn; }
VFileContent* contentp() const { return m_contentp; }
std::shared_ptr<VFileContent> contentp() const { return m_contentp; }
// If not otherwise more specific, use last lineno for errors etc,
// as the parser errors etc generally make more sense pointing at the last parse point
int lineno() const { return m_lastLineno; }