github/verilator
1
0
Fork 1
mirror of https://github.com/verilator/verilator.git synced 2025-01-01 04:07:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

Internals: Add missing VL_RESTORERS to V3LinkLValue; probably fixes no real cases, bug better safe.

Browse Source
This commit is contained in:
Wilson Snyder 2024-11-05 00:03:23 -05:00
parent eaaf91c82b
commit 2e4676dc11
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/V3LinkLValue.cpp
View File

@ -36,11 +36,9 @@ class LinkLValueVisitor final : public VNVisitor {
bool m_setContinuously = false; // Set that var has some continuous assignment bool m_setContinuously = false; // Set that var has some continuous assignment
bool m_setForcedByCode = false; // Set that var is the target of an AstAssignForce/AstRelease bool m_setForcedByCode = false; // Set that var is the target of an AstAssignForce/AstRelease
bool m_setIfRand = false; // Update VarRefs if var declared as rand bool m_setIfRand = false; // Update VarRefs if var declared as rand
bool m_inInitialStatic = false; // Set if inside AstInitialStatic
bool m_inFunc = false; // Set if inside AstNodeFTask
// STATE - TODO
bool m_setStrengthSpecified = false; // Set that var has assignment with strength specified. bool m_setStrengthSpecified = false; // Set that var has assignment with strength specified.
bool m_inFunc = false; // Set if inside AstNodeFTask
bool m_inInitialStatic = false; // Set if inside AstInitialStatic
VAccess m_setRefLvalue; // Set VarRefs to lvalues for pin assignments VAccess m_setRefLvalue; // Set VarRefs to lvalues for pin assignments
// VISITs // VISITs
@ -76,6 +74,7 @@ class LinkLValueVisitor final : public VNVisitor {
// Nodes that start propagating down lvalues // Nodes that start propagating down lvalues
void visit(AstPin* nodep) override { void visit(AstPin* nodep) override {
VL_RESTORER(m_setRefLvalue);
if (nodep->modVarp() && nodep->modVarp()->isWritable()) { if (nodep->modVarp() && nodep->modVarp()->isWritable()) {
// When the varref's were created, we didn't know the I/O state // When the varref's were created, we didn't know the I/O state
// Now that we do, and it's from a output, we know it's a lvalue // Now that we do, and it's from a output, we know it's a lvalue
@ -89,6 +88,7 @@ class LinkLValueVisitor final : public VNVisitor {
void visit(AstNodeAssign* nodep) override { void visit(AstNodeAssign* nodep) override {
VL_RESTORER(m_setRefLvalue); VL_RESTORER(m_setRefLvalue);
VL_RESTORER(m_setContinuously); VL_RESTORER(m_setContinuously);
VL_RESTORER(m_setStrengthSpecified);
{ {
m_setRefLvalue = VAccess::WRITE; m_setRefLvalue = VAccess::WRITE;
m_setContinuously = VN_IS(nodep, AssignW) || VN_IS(nodep, AssignAlias); m_setContinuously = VN_IS(nodep, AssignW) || VN_IS(nodep, AssignAlias);
@ -317,9 +317,9 @@ class LinkLValueVisitor final : public VNVisitor {
AstNodeExpr* const pinp = argp->exprp(); AstNodeExpr* const pinp = argp->exprp();
if (!pinp) continue; if (!pinp) continue;
if (portp->isWritable()) { if (portp->isWritable()) {
VL_RESTORER(m_setRefLvalue);
m_setRefLvalue = VAccess::WRITE; m_setRefLvalue = VAccess::WRITE;
iterate(pinp); iterate(pinp);
m_setRefLvalue = VAccess::NOCHANGE;
} else { } else {
iterate(pinp); iterate(pinp);
} }