github/verilator
1
0
Fork 1
mirror of https://github.com/verilator/verilator.git synced 2025-01-01 04:07:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix $system with string argument (#5042).

Browse Source
This commit is contained in:
Wilson Snyder 2024-04-11 17:31:14 -04:00
parent a8b5738b44
commit 1012c054e6
4 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
Changes
View File

@ -13,6 +13,7 @@ Verilator 5.025 devel
**Minor:**
* Fix `$system` with string argument (#5042).
Verilator 5.024 2024-04-05

5
include/verilated.cpp
View File

@ -1749,7 +1749,10 @@ IData VL_SYSTEM_IQ(QData lhs) VL_MT_SAFE {
IData VL_SYSTEM_IW(int lhswords, const WDataInP lhsp) VL_MT_SAFE {
char filenamez[VL_VALUE_STRING_MAX_CHARS + 1];
_vl_vint_to_string(lhswords * VL_EDATASIZE, filenamez, lhsp);
const int code = std::system(filenamez); // Yes, std::system() is threadsafe
return VL_SYSTEM_IN(filenamez);
}
IData VL_SYSTEM_IN(const std::string& lhs) VL_MT_SAFE {
const int code = std::system(lhs.c_str()); // Yes, std::system() is threadsafe
return code >> 8; // Want exit status
}

1
include/verilated_funcs.h
View File

@ -152,6 +152,7 @@ extern std::string VL_STACKTRACE_N() VL_MT_SAFE;
extern IData VL_SYSTEM_IW(int lhswords, WDataInP const lhsp) VL_MT_SAFE;
extern IData VL_SYSTEM_IQ(QData lhs) VL_MT_SAFE;
inline IData VL_SYSTEM_II(IData lhs) VL_MT_SAFE { return VL_SYSTEM_IQ(lhs); }
extern IData VL_SYSTEM_IN(const std::string& lhs) VL_MT_SAFE;
extern IData VL_TESTPLUSARGS_I(const std::string& format) VL_MT_SAFE;
extern const char* vl_mc_scan_plusargs(const char* prefixp) VL_MT_SAFE; // PLIish

4
test_regress/t/t_sys_system.v
View File

@ -7,6 +7,7 @@
module t;
integer i;
string s;
initial begin
`ifndef VERILATOR
@ -26,6 +27,9 @@ module t;
if (i!==10) $stop;
i = $system("exit 20"); // Wide
if (i!==20) $stop;
s = "exit 10";
i = $system(s); // String
if (i!==10) $stop;
`endif
$write("*-* All Finished *-*\n");