Internals: Remove redundant initial clears. No functional change intended.

docs/internals.adoc

@@ -586,7 +586,7 @@ dealing with. For example a visitor might not implement separate `visit`
 methods for `AstIf` and `AstGenIf`, but just a single method for the base
 class:
 
-   void visit (AstNodeIf* nodep)
+   void visit(AstNodeIf* nodep)
 
 However that method might want to specify additional code if it is called
 for `AstGenIf`. Verilator does this by providing a `VN_IS` method for each
@@ -672,7 +672,7 @@ Set to 1 to indicate that the compilation or execution is intended to fail.
 For example the following would specify that compilation requires two
 defines and is expected to fail.
 
-   compile (
+   compile(
       verilator_flags2 => ["-DSMALL_CLOCK -DGATED_COMMENT"],
       fails => 1,
       );

src/V3Gate.cpp

@@ -525,10 +525,7 @@ private:
 
 public:
     // CONSTRUCTORS
-    explicit GateVisitor(AstNode* nodep) {
+    explicit GateVisitor(AstNode* nodep) { iterate(nodep); }
-        AstNode::user1ClearTree();
-        iterate(nodep);
-    }
     virtual ~GateVisitor() override {
         V3Stats::addStat("Optimizations, Gate sigs deleted", m_statSigs);
         V3Stats::addStat("Optimizations, Gate inputs replaced", m_statRefs);

src/V3SplitAs.cpp

@@ -183,10 +183,7 @@ private:
 
 public:
     // CONSTRUCTORS
-    explicit SplitAsVisitor(AstNetlist* nodep) {
+    explicit SplitAsVisitor(AstNetlist* nodep) { iterate(nodep); }
-        AstNode::user1ClearTree();  // user1p() used on entire tree
-        iterate(nodep);
-    }
     virtual ~SplitAsVisitor() override {
         V3Stats::addStat("Optimizations, isolate_assignments blocks", m_statSplits);
     }

src/V3Subst.cpp

@@ -365,11 +365,7 @@ private:
 
 public:
     // CONSTRUCTORS
-    explicit SubstVisitor(AstNode* nodep) {
+    explicit SubstVisitor(AstNode* nodep) { iterate(nodep); }
-        AstNode::user1ClearTree();  // user1p() used on entire tree
-        AstNode::user2ClearTree();  // user2p() used on entire tree
-        iterate(nodep);
-    }
     virtual ~SubstVisitor() override {
         V3Stats::addStat("Optimizations, Substituted temps", m_statSubsts);
         for (SubstVarEntry* ip : m_entryps) {

src/V3Task.cpp

@@ -1374,7 +1374,6 @@ public:
     // CONSTRUCTORS
     TaskVisitor(AstNetlist* nodep, TaskStateVisitor* statep)
         : m_statep{statep} {
-        AstNode::user1ClearTree();
         iterate(nodep);
     }
     virtual ~TaskVisitor() override {}