From a8ce272e4a2e397e39abeff7fe06acbd8c5ae0e0 Mon Sep 17 00:00:00 2001 From: Wilson Snyder Date: Tue, 14 Mar 2023 08:39:04 -0400 Subject: [PATCH] Commentary: spelling --- Changes | 12 ++++++------ docs/guide/warnings.rst | 4 ++-- docs/spelling.txt | 18 +++++++++++++++++- src/V3Param.cpp | 2 +- test_regress/t/t_dist_whitespace.pl | 3 ++- 5 files changed, 28 insertions(+), 11 deletions(-) diff --git a/Changes b/Changes index b24b28d84..b3da19ca6 100644 --- a/Changes +++ b/Changes @@ -56,8 +56,8 @@ Verilator 5.008 2023-03-04 * Fix namespace fallback resolution (#3863) (#3942). [Aleksander Kiryk, Antmicro Ltd] * Fix std:: to be parsed first (#3864) (#3928). [Aleksander Kiryk, Antmicro Ltd] * Fix cmake warning if multiple SOURCES w/o PREFIX (#3916) (#3927). [Yoda Lee] -* Fix paramaterized class function linkage (#3917). [Ryszard Rozak] -* Fix static members of type aliases of a parametrized class (#3922). [Ryszard Rozak, Antmicro Ltd] +* Fix parameterized class function linkage (#3917). [Ryszard Rozak] +* Fix static members of type aliases of a parameterized class (#3922). [Ryszard Rozak, Antmicro Ltd] * Fix class extend parameter dot case (#3926). [Ryszard Rozak, Antmicro Ltd] * Fix MsWin missing directory exception, and ::std (#3928) (#3933) (#3935). [Kritik Bhimani] * Fix very long VPI signal names (#3929). [Marlon James] @@ -69,13 +69,13 @@ Verilator 5.008 2023-03-04 * Fix CMake bad C identifiers (#3948) (#3951). [Zixi Li] * Fix build on HP PA architecture (#3954). [John David Anglin] * Fix date on the front page of verilator.pdf (#3956) (#3957). [Larry Doolittle] -* Fix dicts declared with ref type (#3960). [Ryszard Rozak, Antmicro Ltd] +* Fix associative arrays declared with ref type (#3960). [Ryszard Rozak, Antmicro Ltd] * Fix missing error on negative replicate (#3963). [Benjamin Menküc] * Fix self references to parameterized classes (#3962). [Ryszard Rozak, Antmicro Ltd] * Fix LITENDIAN warning is backwards (#3966) (#3967). [Cameron Kirk] * Fix subsequent parameter declarations (#3969). [Ryszard Rozak, Antmicro Ltd] * Fix timing delays to not truncate below 64 bits (#3973) (#3982). [Felix Neumärker] -* Fix cmake on macOS to mark weak symbols with -U linker flag (#3978) (#3979). [Peter Debacker] +* Fix cmake on MacOS to mark weak symbols with -U linker flag (#3978) (#3979). [Peter Debacker] * Fix UNDRIVEN warning seg fault (#3989). [Felix Neumärker] * Fix coverage of class methods (#3998). [Tim Paine] * Fix packed array structure replication. @@ -95,7 +95,7 @@ Verilator 5.006 2023-01-22 * Support import/export lists in modport (#3886). [Gökçe Aydos] * Support class queue equality (#3895). [Ilya Barkov] * Support type case and type equality comparisons. -* Add IMPLICITSTATIC warning when a ftask/function is implicitly static (#3839). [Ryszard Rozak, Antmicro Ltd] +* Add IMPLICITSTATIC warning when a task/function is implicitly static (#3839). [Ryszard Rozak, Antmicro Ltd] * Add VL_VALUE_STRING_MAX_WORDS override (#3869). [Andrew Nolte] * Optimize expansion of extend operators. * Internal multithreading tests. [Mariusz Glebocki, et al, Antmicro Ltd] @@ -109,7 +109,7 @@ Verilator 5.006 2023-01-22 * Fix self references when param class instantiated (#3833). [Ryszard Rozak, Antmicro Ltd] * Fix memory leak in V3Sched, etc. (#3834). [Geza Lore] * Fix compatibility with musl libc / Alpine Linux (#3845). [Sören Tempel] -* Fix empty case items crash (#3851). [rporter] +* Fix empty case items crash (#3851). [Rich Porter] * Fix VL_CPU_RELAX on MIPS/Armel/s390/sparc (#3843) (#3891). [Kamil Rakoczy] * Fix module parameter name collision (#3854) (#3855). [James Shi] * Fix unpacked array expansion (#3861). [Joey Liu] diff --git a/docs/guide/warnings.rst b/docs/guide/warnings.rst index ccfb0e763..e19c6a6a1 100644 --- a/docs/guide/warnings.rst +++ b/docs/guide/warnings.rst @@ -738,7 +738,7 @@ List Of Warnings This is a warning because the static default differs from C++, differs from class member function/tasks. Static is a more dangerous default - then automatic as static prevents the function from being reinterant, + then automatic as static prevents the function from being reentrant, which may be a source of bugs, and/or performance issues. If the function does not require static behavior, change it to "function @@ -1813,7 +1813,7 @@ List Of Warnings .. option:: WIDTHXZEXPAND - A more granular WIDTH warning, for when a value is xz expanded + A more granular WIDTH warning, for when a value is X/Z expanded .. option:: WIDTHCONCAT diff --git a/docs/spelling.txt b/docs/spelling.txt index b77ffb233..9098225a7 100644 --- a/docs/spelling.txt +++ b/docs/spelling.txt @@ -6,6 +6,7 @@ Alexandre Ami Amir Anastasiadis +Anglin Anikin Antmicro Antonin @@ -42,6 +43,7 @@ Chandan Chitlesh Christophe Cochrane +Corteggiani Cuan Cygwin DErrico @@ -96,6 +98,7 @@ Fredieu GTKWave Galbi Gantt +Garnal Gartner Gelinek Geoff @@ -207,6 +210,7 @@ Matveyenko Maupin Mdir Mednick +Menküc Michiels Microsystems Milanovic @@ -223,8 +227,10 @@ Muhlestein Multithreaded Multithreading NOUNOPTFLAT +NaN Nalbantis Narayan +Nassim Nauticus Newgard Nigam @@ -376,6 +382,7 @@ Xuan Xuanqi Yazdanbakhsh Yi +Yike Yinan Yosys Yu @@ -452,6 +459,7 @@ commandArgsPlusMatch compilable concat concats +conf config const constexpr @@ -512,6 +520,7 @@ dumpportson dumpvars dut dx +dynarray elab elike elsif @@ -541,6 +550,7 @@ exe executables expr extern +ezchi fanin fasttrace fauto @@ -635,6 +645,7 @@ lcov ld leavinel len +libc libext libgoogle libsystemc @@ -653,6 +664,7 @@ logicals longint lossy lsb +lubc lvalue lxt macromodule @@ -678,12 +690,15 @@ mtasks mulithreaded mult multidim +multidriven multiinterfaces multiline multipling +multipoint multithread multithreaded multithreading +musl mutexes mux myftptoyman @@ -762,6 +777,7 @@ pulldowns pullup pvalue pwd +py qrq radix randc @@ -909,6 +925,7 @@ vlt vltstd vluint vpi +vpiDefName vpiLeftRange vpiModule vpiSize @@ -938,4 +955,3 @@ ypq yurivict zdave Øyvind - diff --git a/src/V3Param.cpp b/src/V3Param.cpp index 287968268..741d102d8 100644 --- a/src/V3Param.cpp +++ b/src/V3Param.cpp @@ -1022,7 +1022,7 @@ class ParamVisitor final : public VNVisitor { m_cellps.emplace(!isIface, nodep); } - // RHSs of AstDots need a relink when LHS is a parametrized class reference + // RHSs of AstDots need a relink when LHS is a parameterized class reference void relinkDots() { for (AstDot* const dotp : m_dots) { const AstClassOrPackageRef* const classRefp = VN_AS(dotp->lhsp(), ClassOrPackageRef); diff --git a/test_regress/t/t_dist_whitespace.pl b/test_regress/t/t_dist_whitespace.pl index 3a09d63e7..5fcf0c9c3 100755 --- a/test_regress/t/t_dist_whitespace.pl +++ b/test_regress/t/t_dist_whitespace.pl @@ -67,7 +67,8 @@ foreach my $file (sort keys %files) { if ($contents =~ /[^[:alnum:][:punct:] \t\r\n]/) { my $unicode_exempt = ($file =~ /Changes$/ || $file =~ /CONTRIBUTORS$/ - || $file =~ /contributors.rst$/); + || $file =~ /contributors.rst$/ + || $file =~ /spelling.txt$/); next if $unicode_exempt; $warns{$file} = "Warning: non-ASCII contents in $file\n"; }