From 9d3e800311b85e879672c43f402adf694e35e4c1 Mon Sep 17 00:00:00 2001 From: Wilson Snyder Date: Sun, 13 Jun 2021 11:18:37 -0400 Subject: [PATCH] Commentary --- docs/internals.rst | 6 +++--- src/V3PreShell.cpp | 2 +- test_regress/driver.pl | 6 +++--- test_regress/t/t_assert_cover.pl | 2 +- test_regress/t/t_cover_sva_notflat.pl | 2 +- 5 files changed, 9 insertions(+), 9 deletions(-) diff --git a/docs/internals.rst b/docs/internals.rst index 71eebfb41..39e3d3862 100644 --- a/docs/internals.rst +++ b/docs/internals.rst @@ -502,7 +502,7 @@ Some of the code implementing passes is extremely repetitive, and must be implemented for each sub-class of ``AstNode``. However, while repetitive, there is more variability than can be handled in C++ macros. -In Verilator this is implemented by using a Perl script, ``astgen`` to +In Verilator this is implemented by using a script, ``astgen`` to pre-process the C++ code. For example in ``V3Const.cpp`` this is used to implement the ``visit()`` functions for each binary operation using the ``TREEOP`` macro. @@ -750,8 +750,8 @@ test. For run-time tests, this is followed by a call to the ``execute`` subroutine. Both of these functions can optionally be provided with a hash table as argument specifying additional options. -The test driver assumes by default that the source Verilog file name -matches the PERL driver name. So a test whose driver is +The driver.pl script assumes by default that the source Verilog file name +matches the test script name. So a test whose driver is ``t/t_mytest.pl`` will expect a Verilog source file ``t/t_mytest.v``. This can be changed using the ``top_filename`` subroutine, for example diff --git a/src/V3PreShell.cpp b/src/V3PreShell.cpp index 66b7d5f1c..2c8bc4ed8 100644 --- a/src/V3PreShell.cpp +++ b/src/V3PreShell.cpp @@ -160,7 +160,7 @@ V3PreProc* V3PreShellImp::s_preprocp = nullptr; VInFilter* V3PreShellImp::s_filterp = nullptr; //###################################################################### -// Perl class functions +// V3PreShell void V3PreShell::boot(char** env) { V3PreShellImp::s_preImp.boot(env); } bool V3PreShell::preproc(FileLine* fl, const string& modname, VInFilter* filterp, diff --git a/test_regress/driver.pl b/test_regress/driver.pl index 54dd82683..37a7d309e 100755 --- a/test_regress/driver.pl +++ b/test_regress/driver.pl @@ -2532,9 +2532,9 @@ with many cores. See the -j option and OBJCACHE environment variable. =head1 TEST CONFIGURATION -The Perl script (e.g. C) controls how the test -will run by driver.pl. In general it includes a call to the C -subroutine to compile the test with Verilator (or an alternative +The test configuration script (e.g. C) controls +how the test will run by driver.pl. In general it includes a call to the +C subroutine to compile the test with Verilator (or an alternative simulator), followed by a call to the C subroutine to run the test. Compile-only tests omit the call to C. diff --git a/test_regress/t/t_assert_cover.pl b/test_regress/t/t_assert_cover.pl index f308ab3df..e72a962af 100755 --- a/test_regress/t/t_assert_cover.pl +++ b/test_regress/t/t_assert_cover.pl @@ -41,7 +41,7 @@ file_grep($Self->{run_log_filename}, qr/COVER: Cyc==4/); file_grep($Self->{run_log_filename}, qr/COVER: Cyc==5/); file_grep($Self->{run_log_filename}, qr/COVER: Cyc==6/); -# Allow old Perl format dump, or new binary dump +# Allow old SystemC::Coverage format dump, or new binary dump file_grep($Self->{coverage_filename}, qr/(cyc_eq_5.*,c=>[^0]|cyc_eq_5.* [1-9][0-9]*\n)/); ok(1); diff --git a/test_regress/t/t_cover_sva_notflat.pl b/test_regress/t/t_cover_sva_notflat.pl index a509d42b8..5effab8e8 100755 --- a/test_regress/t/t_cover_sva_notflat.pl +++ b/test_regress/t/t_cover_sva_notflat.pl @@ -20,7 +20,7 @@ execute( #if ($Self->{nc}) ... # See t_assert_cover.pl for NC version -# Allow old Perl format dump, or new binary dump +# Allow old SystemC::Coverage format dump, or new binary dump # Check that the hierarchy doesn't include __PVT__ # Otherwise our coverage reports would look really ugly if ($Self->{vlt_all}) {