Mario1159/verilator
1
0
Fork 0
forked from github/verilator
Code Pull Requests Releases 1 Activity

Internals: Remove DETECTARRAY, dead code.

Browse Source
This commit is contained in:
Wilson Snyder 2022-10-16 09:41:39 -04:00
parent 3cd2c8532d
commit 76ccd332a6
5 changed files with 5 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
docs/guide/warnings.rst
View File

@ -465,15 +465,11 @@ List Of Warnings
.. option:: DETECTARRAY .. option:: DETECTARRAY
.. TODO better example Historical, never issued since version 3.862.
Error when Verilator tries to deal with a combinatorial loop that could Was an error when Verilator tried to deal with a combinatorial loop that
not be flattened, and which involves a datatype which Verilator cannot could not be flattened, and which involves a datatype which Verilator
handle, such as an unpacked struct or a large unpacked array. This could not handle, such as an unpacked struct or a large unpacked array.
typically occurs when :vlopt:`-Wno-UNOPTFLAT <UNOPTFLAT>` has been used
to override an UNOPTFLAT warning (see below).
The solution is to break the loop, as described for UNOPTFLAT.
.. option:: DIDNOTCONVERGE .. option:: DIDNOTCONVERGE

3
src/V3Error.h
View File

@ -54,7 +54,6 @@ public:
I_DEF_NETTYPE_WIRE, // `default_nettype is WIRE (false=NONE) I_DEF_NETTYPE_WIRE, // `default_nettype is WIRE (false=NONE)
I_TIMING, // Enable timing from /*verilator timing_on/off*/ I_TIMING, // Enable timing from /*verilator timing_on/off*/
// Error codes: // Error codes:
E_DETECTARRAY, // Error: Unsupported: Can't detect changes on arrayed variable
E_ENCAPSULATED, // Error: local/protected violation E_ENCAPSULATED, // Error: local/protected violation
E_PORTSHORT, // Error: Output port is connected to a constant, electrical short E_PORTSHORT, // Error: Output port is connected to a constant, electrical short
E_UNSUPPORTED, // Error: Unsupported (generally) E_UNSUPPORTED, // Error: Unsupported (generally)
@ -167,7 +166,7 @@ public:
// Boolean // Boolean
" I_CELLDEFINE", " I_COVERAGE", " I_TRACING", " I_LINT", " I_DEF_NETTYPE_WIRE", " I_TIMING", " I_CELLDEFINE", " I_COVERAGE", " I_TRACING", " I_LINT", " I_DEF_NETTYPE_WIRE", " I_TIMING",
// Errors // Errors
"DETECTARRAY", "ENCAPSULATED", "PORTSHORT", "UNSUPPORTED", "TASKNSVAR", "NEEDTIMINGOPT", "NOTIMING", "ENCAPSULATED", "PORTSHORT", "UNSUPPORTED", "TASKNSVAR", "NEEDTIMINGOPT", "NOTIMING",
// Warnings // Warnings
" EC_FIRST_WARN", " EC_FIRST_WARN",
"ALWCOMBORDER", "ASSIGNDLY", "ASSIGNIN", "BADSTDPRAGMA", "ALWCOMBORDER", "ASSIGNDLY", "ASSIGNIN", "BADSTDPRAGMA",

2
test_regress/t/t_detectarray_1.v
View File

@ -1,7 +1,5 @@
// DESCRIPTION: Verilator: Simple test of unoptflat // DESCRIPTION: Verilator: Simple test of unoptflat
// //
// Trigger the DETECTARRAY error.
//
// This file ONLY is placed into the Public Domain, for any use, // This file ONLY is placed into the Public Domain, for any use,
// without warranty, 2013 by Jeremy Bennett. // without warranty, 2013 by Jeremy Bennett.
// SPDX-License-Identifier: CC0-1.0 // SPDX-License-Identifier: CC0-1.0

4
test_regress/t/t_detectarray_2.v
View File

@ -1,9 +1,5 @@
// DESCRIPTION: Verilator: Simple test of unoptflat // DESCRIPTION: Verilator: Simple test of unoptflat
// //
// This should trigger the DETECTARRAY error like t_detectarray_1.v, but in
// fact it casuses a broken link error. The only difference is that the struct
// is defined using a constant rather than a localparam.
//
// This file ONLY is placed into the Public Domain, for any use, // This file ONLY is placed into the Public Domain, for any use,
// without warranty, 2013 by Jeremy Bennett. // without warranty, 2013 by Jeremy Bennett.
// SPDX-License-Identifier: CC0-1.0 // SPDX-License-Identifier: CC0-1.0

2
test_regress/t/t_detectarray_3.v
View File

@ -1,7 +1,5 @@
// DESCRIPTION: Verilator: Simple test of unoptflat // DESCRIPTION: Verilator: Simple test of unoptflat
// //
// Trigger the DETECTARRAY error on packed structure.
//
// This file ONLY is placed into the Public Domain, for any use, // This file ONLY is placed into the Public Domain, for any use,
// without warranty, 2014 by Jie Xu. // without warranty, 2014 by Jie Xu.
// SPDX-License-Identifier: CC0-1.0 // SPDX-License-Identifier: CC0-1.0