Suppress 'command failed' on normal errors.

Changes

@@ -16,6 +16,8 @@ The contributors that suggested a given feature are shown in []. Thanks!
 
 ***   Support multithreading on Windows. [Patrick Stewart]
 
+***   Suppress 'command failed' on normal errors.
+
 ****  Increase case duplicate/incomplete to 16 bit tables, bug1545. [Yossi Nivin]
 
 ****  Support quoted arguments in -f files, bug1535. [Yves Mathieu]

bin/verilator

@@ -197,14 +197,12 @@ sub run {
                 warn "%Error: Verilator threw signal $status.  Consider trying --debug --gdbbt\n" if !$Debug;
             }
         }
-        if ($opt_quiet_exit) {
-            # Same return code as die
-            exit $! if $!;  # errno
-            exit $? >> 8 if $? >> 8;  # child exit status
-            exit 255;  # last resort
-        } else {
-            die "%Error: Command Failed $command\n";
+        if (!$opt_quiet_exit && ($status != 256 || $Debug)) {  # i.e. not normal exit(1)
+            warn "%Error: Command Failed $command\n";
         }
+        exit $! if $!;  # errno
+        exit $? >> 8 if $? >> 8;  # child exit status
+        exit 255;  # last resort
     }
 }
 

bin/verilator_coverage

@@ -134,7 +134,12 @@ sub run {
                 warn "%Error: Verilator_coverage threw signal $status.\n" if !$Debug;
             }
         }
-        die "%Error: Command Failed $command\n";
+        if ($status != 256 || $Debug) {  # i.e. not normal exit(1)
+            warn "%Error: Command Failed $command\n";
+        }
+        exit $! if $!;  # errno
+        exit $? >> 8 if $? >> 8;  # child exit status
+        exit 255;  # last resort
     }
 }
 

src/V3Error.cpp

@@ -141,7 +141,7 @@ void V3Error::vlAbort() {
         std::cerr<<msgPrefix()<<"Aborting since under --debug"<<endl;
         abort();
     } else {
-        exit(10);
+        exit(1);
     }
 }
 

src/V3File.cpp

@@ -488,7 +488,7 @@ private:
             execl("/bin/sh", "sh", "-c", command.c_str(), static_cast<char*>(NULL));
             // Don't use v3fatal, we don't share the common structures any more
             fprintf(stderr, "--pipe-filter: exec failed: %s\n", strerror(errno));
-            _exit(10);
+            _exit(1);
         }
         else {  // Parent
             UINFO(6,"In parent, child pid "<<pid

test_regress/t/t_debug_fatalsrc_bad.pl

@@ -14,8 +14,7 @@ compile(
     fails => $Self->{vlt_all},
     expect =>
 '%Error: Internal Error: .*: --debug-fatal-src
-.* See the manual and .*
-%Error: Command Failed.*',
+.* See the manual and .*',
     );
 
 ok(1);

test_regress/t/t_lint_comb_bad.out

@@ -2,4 +2,3 @@
    always_comb @(*) begin
                ^
 %Error: Cannot continue
-%Error: Command Failed

test_regress/t/t_prot_lib_inout_bad.out

@@ -2,4 +2,3 @@
                     inout  z,
                            ^
                         ... See the manual and http://www.veripool.org/verilator for more assistance.
-%Error: Command Failed

test_regress/t/t_prot_lib_unpacked_bad.out

@@ -2,4 +2,3 @@
                     input  unpacked_in [7:0],
                            ^~~~~~~~~~~
                         ... See the manual and http://www.veripool.org/verilator for more assistance.
-%Error: Command Failed

test_regress/t/t_vlcov_nfound_bad.out

@@ -1,2 +1 @@
 %Error: Can't read t/t_NOT_FOUND
-%Error: Command Failed