Mario1159/verilator
1
0
Fork 0
forked from github/verilator
Code Pull Requests Releases 1 Activity

Fix class constructor error on assignments to const.

Browse Source
This commit is contained in:
Wilson Snyder 2020-08-22 22:44:00 -04:00
parent 7f3a73e314
commit 4e6d2cfe38
3 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Changes
View File

@ -15,6 +15,8 @@ The contributors that suggested a given feature are shown in []. Thanks!
**** Fix naming of "id : begin" blocks. **** Fix naming of "id : begin" blocks.
**** Fix class constructor error on assignments to const.
* Verilator 4.040 2020-08-15 * Verilator 4.040 2020-08-15

1
src/V3Width.cpp
View File

@ -1793,6 +1793,7 @@ private:
if (nodep->lvalue() && nodep->varp()->direction() == VDirection::CONSTREF) { if (nodep->lvalue() && nodep->varp()->direction() == VDirection::CONSTREF) {
nodep->v3error("Assigning to const ref variable: " << nodep->prettyNameQ()); nodep->v3error("Assigning to const ref variable: " << nodep->prettyNameQ());
} else if (nodep->lvalue() && nodep->varp()->isConst() && !m_paramsOnly } else if (nodep->lvalue() && nodep->varp()->isConst() && !m_paramsOnly
&& (!m_ftaskp || !m_ftaskp->isConstructor())
&& !VN_IS(m_procedurep, Initial)) { && !VN_IS(m_procedurep, Initial)) {
// Too loose, but need to allow our generated first assignment // Too loose, but need to allow our generated first assignment
// Move this to a property of the AstInitial block // Move this to a property of the AstInitial block

2
test_regress/t/t_class_new.v
View File

@ -5,7 +5,7 @@
// SPDX-License-Identifier: CC0-1.0 // SPDX-License-Identifier: CC0-1.0
class ClsNoArg; class ClsNoArg;
int imembera; const int imembera; // Ok for new() to assign to a const
function new(); function new();
imembera = 5; imembera = 5;
endfunction endfunction