Mario1159/verilator
1
0
Fork 0
forked from github/verilator
Code Pull Requests Releases 1 Activity

Fix clang warnings from override.

Browse Source
This commit is contained in:
Wilson Snyder 2020-01-21 20:22:32 -05:00
parent 220daa5f33
commit 48dd358c03
2 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/V3Split.cpp
View File

@ -457,7 +457,7 @@ public:
// METHODS // METHODS
protected: protected:
void makeRvalueEdges(SplitVarStdVertex* vstdp) { virtual void makeRvalueEdges(SplitVarStdVertex* vstdp) VL_OVERRIDE {
for (VStack::iterator it = m_stmtStackps.begin(); it != m_stmtStackps.end(); ++it) { for (VStack::iterator it = m_stmtStackps.begin(); it != m_stmtStackps.end(); ++it) {
new SplitRVEdge(&m_graph, *it, vstdp); new SplitRVEdge(&m_graph, *it, vstdp);
} }
@ -876,7 +876,7 @@ public:
// METHODS // METHODS
protected: protected:
void makeRvalueEdges(SplitVarStdVertex* vstdp) { virtual void makeRvalueEdges(SplitVarStdVertex* vstdp) VL_OVERRIDE {
// Each 'if' depends on rvalues in its own conditional ONLY, // Each 'if' depends on rvalues in its own conditional ONLY,
// not rvalues in the if/else bodies. // not rvalues in the if/else bodies.
for (VStack::const_iterator it = m_stmtStackps.begin(); it != m_stmtStackps.end(); ++it) { for (VStack::const_iterator it = m_stmtStackps.begin(); it != m_stmtStackps.end(); ++it) {

5
src/astgen
View File

@ -627,7 +627,7 @@ sub tree_base {
# saves one comparison. # saves one comparison.
if ($out_for_type_sc[0]) { # Short-circuited types if ($out_for_type_sc[0]) { # Short-circuited types
$self->print(" // Generated by astgen with short-circuiting\n", $self->print(" // Generated by astgen with short-circuiting\n",
" virtual void visit(Ast${type}* nodep) {\n", " virtual void visit(Ast${type}* nodep) VL_OVERRIDE {\n",
" iterateAndNextNull(nodep->lhsp());\n", " iterateAndNextNull(nodep->lhsp());\n",
@out_for_type_sc); @out_for_type_sc);
$self->print(" iterateAndNextNull(nodep->rhsp());\n", $self->print(" iterateAndNextNull(nodep->rhsp());\n",
@ -638,8 +638,9 @@ sub tree_base {
} elsif ($out_for_type[0]) { # Other types with something to print } elsif ($out_for_type[0]) { # Other types with something to print
my $skip = $self->{tree_skip_visit}{$type}; my $skip = $self->{tree_skip_visit}{$type};
my $gen = $skip ? "Gen" : ""; my $gen = $skip ? "Gen" : "";
my $override = $skip ? "" : " VL_OVERRIDE";
$self->print(" // Generated by astgen\n", $self->print(" // Generated by astgen\n",
" virtual void visit$gen(Ast${type}* nodep) {\n", " virtual void visit$gen(Ast${type}* nodep)${override} {\n",
($skip?"": ($skip?"":
" iterateChildren(nodep);\n"), " iterateChildren(nodep);\n"),
@out_for_type, @out_for_type,