From 3e03cd5a4da61b6ad41e88d4f86a2e71ba5b5636 Mon Sep 17 00:00:00 2001 From: Wilson Snyder Date: Wed, 1 Sep 2021 20:39:59 -0400 Subject: [PATCH] Commentary --- Changes | 5 ++++- src/V3Const.cpp | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/Changes b/Changes index 526a53539..d833c1d82 100644 --- a/Changes +++ b/Changes @@ -16,6 +16,7 @@ Verilator 4.211 devel * Fix re-evaluation of logic dependent on state set in DPI exports (#3091). [Geza Lore] * Support unpacked array localparams in tasks/functions (#3078). [Geza Lore] * Support timeunit/timeprecision in $unit. +* Support assignment patterns as children of pins (#3041). [Krzysztof Bieganski] * Add --instr-count-dpi to tune assumed DPI import cost for multithreaded model scheduling. Default value changed to 200 (#3068). [Yinan Xu] * Output files are split based on the set of headers required @@ -23,12 +24,14 @@ Verilator 4.211 devel * Parameter values are now emitted as 'static constexpr' instead of enum. C++ direct references to parameters might require updating (#3077). [Geza Lore] * Refactored Verilated include files; include verilated.h not verilated_heavy.h. -* Add error when constant function under a generate (#3103). [Don Owen] * Add header guards on Dpi.h generated files (#2979). [Tood Strader] +* Add XML ccall, constpool, initarray, and if/while begins (#3080). [Steven Hugg] +* Add error when constant function under a generate (#3103). [Don Owen] * Fix -G to treat simple integer literals as signed (#3060). [Anikin1610] * Fix emitted string array initializers (#2895). [Iztok Jeras] * Fix bitop tree optimization dropping necessary & operator (#3096). [Flavien Solt] * Fix internal error on wide -x-initial unique (#3106). [Alexandre Joannou] +* Fix traces to show array instances with brackets (#3092) (#3095). [Pieter Kapsenberg] Verilator 4.210 2021-07-07 diff --git a/src/V3Const.cpp b/src/V3Const.cpp index daec651bd..6c279f8ad 100644 --- a/src/V3Const.cpp +++ b/src/V3Const.cpp @@ -354,7 +354,7 @@ class ConstBitOpTreeVisitor final : public AstNVisitor { #define CONST_BITOP_SET_FAILED(reason, nodep) setFailed(true, reason, nodep, __LINE__) bool setFailed(bool fail, const char* reason, AstNode* nodep, int line) { - if (fail) { + if (fail && !m_failed) { UINFO(9, "cannot optimize " << m_rootp << " reason:" << reason << " called from line:" << line << " when checking:" << nodep << std::endl); // if (debug() >= 9) m_rootp->dumpTree(std::cout << "Root node:\n");