Mario1159/verilator
1
0
Fork 0
forked from github/verilator
Code Pull Requests Releases 1 Activity

Removed the deprecated lint_off flag -msg; use -rule instead.

Browse Source
This commit is contained in:
Wilson Snyder 2022-01-17 16:04:06 -05:00
parent 0e154b35ef
commit 21e05c43dd
7 changed files with 5 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
Changes
View File

@ -13,6 +13,7 @@ Verilator 4.219 devel
**Minor:** **Minor:**
* Removed the deprecated lint_off flag -msg; use -rule instead.
Verilator 4.218 2022-01-17 Verilator 4.218 2022-01-17

4
docs/guide/deprecations.rst
View File

@ -16,10 +16,6 @@ Verilated_heavy.h
"verilated.h". Verilated_heavy.h is planned for removal no sooner than "verilated.h". Verilated_heavy.h is planned for removal no sooner than
July 2022. July 2022.
Configuration File -msg
The :vlopt:`lint_off` "-msg" option has been replaced with the "-rule"
option. "-msg" is planned for removal no sooner than January 2021.
XML locations XML locations
The XML "fl" attribute has been replaced with the "loc" attribute. "fl" The XML "fl" attribute has been replaced with the "loc" attribute. "fl"
is planned for removal no sooner than January 2021. is planned for removal no sooner than January 2021.

1
src/verilog.l
View File

@ -142,7 +142,6 @@ vnum {vnum1}|{vnum2}|{vnum3}|{vnum4}|{vnum5}
-?"-match" { FL; return yVLT_D_MATCH; } -?"-match" { FL; return yVLT_D_MATCH; }
-?"-model" { FL; return yVLT_D_MODEL; } -?"-model" { FL; return yVLT_D_MODEL; }
-?"-module" { FL; return yVLT_D_MODULE; } -?"-module" { FL; return yVLT_D_MODULE; }
-?"-msg" { FL; return yVLT_D_MSG; }
-?"-mtask" { FL; return yVLT_D_MTASK; } -?"-mtask" { FL; return yVLT_D_MTASK; }
-?"-rule" { FL; return yVLT_D_RULE; } -?"-rule" { FL; return yVLT_D_RULE; }
-?"-task" { FL; return yVLT_D_TASK; } -?"-task" { FL; return yVLT_D_TASK; }

9
src/verilog.y
View File

@ -370,7 +370,6 @@ BISONPRE_VERSION(3.7,%define api.header.include {"V3ParseBison.h"})
%token<fl> yVLT_D_MATCH "--match" %token<fl> yVLT_D_MATCH "--match"
%token<fl> yVLT_D_MODEL "--model" %token<fl> yVLT_D_MODEL "--model"
%token<fl> yVLT_D_MODULE "--module" %token<fl> yVLT_D_MODULE "--module"
%token<fl> yVLT_D_MSG "--msg"
%token<fl> yVLT_D_MTASK "--mtask" %token<fl> yVLT_D_MTASK "--mtask"
%token<fl> yVLT_D_RULE "--rule" %token<fl> yVLT_D_RULE "--rule"
%token<fl> yVLT_D_TASK "--task" %token<fl> yVLT_D_TASK "--task"
@ -6436,10 +6435,6 @@ vltOffFront<errcodeen>:
yVLT_COVERAGE_OFF { $$ = V3ErrorCode::I_COVERAGE; } yVLT_COVERAGE_OFF { $$ = V3ErrorCode::I_COVERAGE; }
| yVLT_TRACING_OFF { $$ = V3ErrorCode::I_TRACING; } | yVLT_TRACING_OFF { $$ = V3ErrorCode::I_TRACING; }
| yVLT_LINT_OFF { $$ = V3ErrorCode::I_LINT; } | yVLT_LINT_OFF { $$ = V3ErrorCode::I_LINT; }
| yVLT_LINT_OFF yVLT_D_MSG idAny
{ $$ = V3ErrorCode((*$3).c_str());
if ($$ == V3ErrorCode::EC_ERROR) { $1->v3error("Unknown Error Code: " << *$3); }
$2->v3warn(DEPRECATED, "Deprecated -msg in configuration files, use -rule instead."); }
| yVLT_LINT_OFF yVLT_D_RULE idAny | yVLT_LINT_OFF yVLT_D_RULE idAny
{ $$ = V3ErrorCode((*$3).c_str()); { $$ = V3ErrorCode((*$3).c_str());
if ($$ == V3ErrorCode::EC_ERROR) { $1->v3error("Unknown Error Code: " << *$3); } } if ($$ == V3ErrorCode::EC_ERROR) { $1->v3error("Unknown Error Code: " << *$3); } }
@ -6449,10 +6444,6 @@ vltOnFront<errcodeen>:
yVLT_COVERAGE_ON { $$ = V3ErrorCode::I_COVERAGE; } yVLT_COVERAGE_ON { $$ = V3ErrorCode::I_COVERAGE; }
| yVLT_TRACING_ON { $$ = V3ErrorCode::I_TRACING; } | yVLT_TRACING_ON { $$ = V3ErrorCode::I_TRACING; }
| yVLT_LINT_ON { $$ = V3ErrorCode::I_LINT; } | yVLT_LINT_ON { $$ = V3ErrorCode::I_LINT; }
| yVLT_LINT_ON yVLT_D_MSG idAny
{ $$ = V3ErrorCode((*$3).c_str());
if ($$ == V3ErrorCode::EC_ERROR) { $1->v3error("Unknown Error Code: " << *$3); }
$2->v3warn(DEPRECATED, "Deprecated -msg in configuration files, use -rule instead."); }
| yVLT_LINT_ON yVLT_D_RULE idAny | yVLT_LINT_ON yVLT_D_RULE idAny
{ $$ = V3ErrorCode((*$3).c_str()); { $$ = V3ErrorCode((*$3).c_str());
if ($$ == V3ErrorCode::EC_ERROR) { $1->v3error("Unknown Error Code: " << *$3); } } if ($$ == V3ErrorCode::EC_ERROR) { $1->v3error("Unknown Error Code: " << *$3); } }

2
test_regress/t/t_vlt_warn.vlt
View File

@ -11,7 +11,7 @@ lint_off -rule CASEINCOMPLETE -file "t/t_vlt_warn.v"
lint_off -rule WIDTH -file "t/t_vlt_warn.v" -lines 19 lint_off -rule WIDTH -file "t/t_vlt_warn.v" -lines 19
lint_off -rule DECLFILENAME -file "*/t_vlt_warn.v" lint_off -rule DECLFILENAME -file "*/t_vlt_warn.v"
// Test wildcard filenames // Test wildcard filenames
lint_off -msg WIDTH -file "*/t_vlt_warn.v" -lines 20-20 lint_off -rule WIDTH -file "*/t_vlt_warn.v" -lines 20-20
// Test global disables // Test global disables
lint_off -file "*/t_vlt_warn.v" -lines 21-21 lint_off -file "*/t_vlt_warn.v" -lines 21-21
// Test match // Test match

7
test_regress/t/t_vlt_warn_bad.out
View File

@ -1,10 +1,7 @@
%Warning-DEPRECATED: t/t_vlt_warn_bad.vlt:12:10: Deprecated -msg in configuration files, use -rule instead.
12 | lint_off -msg WIDTH -file "*/t_vlt_warn.v" -lines 19-19
| ^~~~
... For warning description see https://verilator.org/warn/DEPRECATED?v=latest
... Use "/* verilator lint_off DEPRECATED */" and lint_on around source to disable this message.
%Warning-WIDTH: t/t_vlt_warn.v:21:33: Operator ASSIGN expects 1 bits on the Assign RHS, but Assign RHS's CONST '2'h3' generates 2 bits. %Warning-WIDTH: t/t_vlt_warn.v:21:33: Operator ASSIGN expects 1 bits on the Assign RHS, but Assign RHS's CONST '2'h3' generates 2 bits.
: ... In instance t : ... In instance t
21 | reg width_warn3_var_line20 = 2'b11; 21 | reg width_warn3_var_line20 = 2'b11;
| ^~~~~ | ^~~~~
... For warning description see https://verilator.org/warn/WIDTH?v=latest
... Use "/* verilator lint_off WIDTH */" and lint_on around source to disable this message.
%Error: Exiting due to %Error: Exiting due to

2
test_regress/t/t_vlt_warn_bad.vlt
View File

@ -9,7 +9,7 @@
lint_off -rule CASEINCOMPLETE -file "t/t_vlt_warn.v" lint_off -rule CASEINCOMPLETE -file "t/t_vlt_warn.v"
lint_off -rule WIDTH -file "t/t_vlt_warn.v" -lines 18 lint_off -rule WIDTH -file "t/t_vlt_warn.v" -lines 18
// Test wildcard filenames // Test wildcard filenames
lint_off -msg WIDTH -file "*/t_vlt_warn.v" -lines 19-19 lint_off -rule WIDTH -file "*/t_vlt_warn.v" -lines 19-19
// Test global disables // Test global disables
lint_off -file "*/t_vlt_warn.v" -lines 20-20 lint_off -file "*/t_vlt_warn.v" -lines 20-20