Mario1159/verilator
1
0
Fork 0
forked from github/verilator
Code Pull Requests Releases 1 Activity

Fix linker errors in user-facing timing functions (#3657)

Browse Source 
Before this change, a design verilated with `--timing` that does not
actually use timing features would be emitted with `eventsPending` and
`nextTimeSlot` declared in the top class. However, their definitions
would be missing, leading to linker errors during design compilation.
This patch makes Verilator always emit the definitions, which prevents
linker errors. Trying to use `nextTimeSlot` without delays in the design
will result in an error at runtime.
This commit is contained in:
Krzysztof Bieganski 2022-10-06 00:16:05 +02:00 committed by GitHub
parent f87fe4c3b4
commit 1a8188e1b4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 14 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
src/V3EmitCModel.cpp
View File

@ -439,22 +439,20 @@ class EmitCModel final : public EmitCFunc {
puts("}\n"); puts("}\n");
} }
if (v3Global.usesTiming()) { putSectionDelimiter("Events and timing");
putSectionDelimiter("Events and timing"); if (auto* const delaySchedp = v3Global.rootp()->delaySchedulerp()) {
if (auto* const delaySchedp = v3Global.rootp()->delaySchedulerp()) { puts("bool " + topClassName() + "::eventsPending() { return !vlSymsp->TOP.");
puts("bool " + topClassName() + "::eventsPending() { return !vlSymsp->TOP."); puts(delaySchedp->nameProtect());
puts(delaySchedp->nameProtect()); puts(".empty(); }\n\n");
puts(".empty(); }\n\n"); puts("uint64_t " + topClassName() + "::nextTimeSlot() { return vlSymsp->TOP.");
puts("uint64_t " + topClassName() + "::nextTimeSlot() { return vlSymsp->TOP."); puts(delaySchedp->nameProtect());
puts(delaySchedp->nameProtect()); puts(".nextTimeSlot(); }\n");
puts(".nextTimeSlot(); }\n"); } else {
} else { puts("bool " + topClassName() + "::eventsPending() { return false; }\n\n");
puts("bool " + topClassName() + "::eventsPending() { return false; }\n\n"); puts("uint64_t " + topClassName() + "::nextTimeSlot() {\n");
puts("uint64_t " + topClassName() + "::nextTimeSlot() {\n"); puts("VL_FATAL_MT(__FILE__, __LINE__, \"\", \"%Error: No delays in the "
puts("VL_FATAL_MT(__FILE__, __LINE__, \"\", \"%Error: No delays in the " "design\");\n");
"design\");\n"); puts("return 0;\n}\n");
puts("return 0;\n}\n");
}
} }
putSectionDelimiter("Utilities"); putSectionDelimiter("Utilities");