Mario1159/verilator
1
0
Fork 0
forked from github/verilator
Code Pull Requests Releases 1 Activity

Suppress REALCVT for whole real numbers.

Browse Source
This commit is contained in:
Wilson Snyder 2020-04-01 18:43:53 -04:00
parent ab058c85bf
commit 19abce5535
3 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Changes
View File

@ -11,6 +11,8 @@ The contributors that suggested a given feature are shown in []. Thanks!
*** Change --quiet-exit to also suppress 'Exiting due to N errors'. *** Change --quiet-exit to also suppress 'Exiting due to N errors'.
**** Suppress REALCVT for whole real numbers.
**** Fix parameter type redeclaring a type, #2195. [hdzhangdoc] **** Fix parameter type redeclaring a type, #2195. [hdzhangdoc]
**** Fix VCD open with empty filename, #2198. [Julius Baxter] **** Fix VCD open with empty filename, #2198. [Julius Baxter]

7
src/V3Width.cpp
View File

@ -4341,6 +4341,13 @@ private:
UINFO(6, " spliceCvtS: " << nodep << endl); UINFO(6, " spliceCvtS: " << nodep << endl);
AstNRelinker linker; AstNRelinker linker;
nodep->unlinkFrBack(&linker); nodep->unlinkFrBack(&linker);
if (AstConst* constp = VN_CAST(nodep, Const)) {
// Ignore obvious conversions of whole real numbers, e.g. 1.0 -> 1
if (constp->isDouble()
&& constp->num().toDouble() == floor(constp->num().toDouble())) {
warnOn = false;
}
}
if (warnOn) nodep->v3warn(REALCVT, "Implicit conversion of real to integer"); if (warnOn) nodep->v3warn(REALCVT, "Implicit conversion of real to integer");
AstNode* newp = new AstRToIRoundS(nodep->fileline(), nodep); AstNode* newp = new AstRToIRoundS(nodep->fileline(), nodep);
linker.relink(newp); linker.relink(newp);

1
test_regress/t/t_lint_realcvt_bad.v
View File

@ -8,5 +8,6 @@ module sub;
integer i; integer i;
initial begin initial begin
i = 23.2; i = 23.2;
i = 23.0; // No warning - often happens with units of time
end end
endmodule endmodule